[
https://issues.apache.org/jira/browse/PHOENIX-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133936#comment-16133936
]
Hadoop QA commented on PHOENIX-4106:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12882703/PHOENIX-4106.patch
against master branch at commit afcebdcae5270e91eefc60eed1da2095d12c4580.
ATTACHMENT ID: 12882703
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
56 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 3 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ HConstants.EMPTY_BYTE_ARRAY,
EnvironmentEdgeManager.currentTimeMillis(),
+ long timeOutForScan = maxQueryEndTime -
EnvironmentEdgeManager.currentTimeMillis();
+ return new MetaDataMutationResult(MutationCode.NO_OP,
EnvironmentEdgeManager.currentTimeMillis(), table);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1277//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1277//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1277//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1277//console
This message is automatically generated.
> Replace System.currentTimeMillis() calls with
> EnvironmentEdgeManager.currentTimeMillis() calls
> ----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4106
> URL: https://issues.apache.org/jira/browse/PHOENIX-4106
> Project: Phoenix
> Issue Type: Test
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4106.patch
>
>
> In order to control the timestamp without using CURRENT_SCN, we need to
> ensure that code always uses EnvironmentEdgeManager.currentTimeMillis().
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
