Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/269#discussion_r134631925
  
    --- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/mapreduce/index/TestIndexScrutinyTableOutput.java
 ---
    @@ -0,0 +1,93 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
    + * agreements. See the NOTICE file distributed with this work for 
additional information regarding
    + * copyright ownership. The ASF licenses this file to you under the Apache 
License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the 
License. You may obtain a
    + * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 
Unless required by applicable
    + * law or agreed to in writing, software distributed under the License is 
distributed on an "AS IS"
    + * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied. See the License
    + * for the specific language governing permissions and limitations under 
the License.
    + */
    +package org.apache.phoenix.mapreduce.index;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +import java.sql.SQLException;
    +import java.util.Arrays;
    +
    +import org.apache.phoenix.mapreduce.util.IndexColumnNames;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +public class TestIndexScrutinyTableOutput extends BaseIndexTest {
    +
    +    private static final long SCRUTINY_TIME_MILLIS = 1502908914193L;
    +
    +    @Before
    +    public void setup() throws Exception {
    +        super.setup();
    +        
conn.createStatement().execute(IndexScrutinyTableOutput.OUTPUT_TABLE_DDL);
    +        
conn.createStatement().execute(IndexScrutinyTableOutput.OUTPUT_METADATA_DDL);
    +        conn.commit();
    --- End diff --
    
    Minor nit: commit() not necessary after DDL


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to