[ 
https://issues.apache.org/jira/browse/PHOENIX-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137665#comment-16137665
 ] 

ASF GitHub Bot commented on PHOENIX-2460:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/269#discussion_r134632028
  
    --- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/mapreduce/index/TestIndexScrutinyTableOutput.java
 ---
    @@ -0,0 +1,93 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
    + * agreements. See the NOTICE file distributed with this work for 
additional information regarding
    + * copyright ownership. The ASF licenses this file to you under the Apache 
License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the 
License. You may obtain a
    + * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 
Unless required by applicable
    + * law or agreed to in writing, software distributed under the License is 
distributed on an "AS IS"
    + * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied. See the License
    + * for the specific language governing permissions and limitations under 
the License.
    + */
    +package org.apache.phoenix.mapreduce.index;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +import java.sql.SQLException;
    +import java.util.Arrays;
    +
    +import org.apache.phoenix.mapreduce.util.IndexColumnNames;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +public class TestIndexScrutinyTableOutput extends BaseIndexTest {
    --- End diff --
    
    Minor nit: Phoenix naming convention (with a few exceptions) is to post fix 
class with "Test": IndexScrutinyTableOutputTest


> Implement scrutiny command to validate whether or not an index is in sync 
> with the data table
> ---------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2460
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2460
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-2460.patch
>
>
> We should have a process that runs to verify that an index is valid against a 
> data table and potentially fixes it if discrepancies are found. This could 
> either be a MR job or a low priority background task.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to