[ 
https://issues.apache.org/jira/browse/PHOENIX-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148130#comment-16148130
 ] 

Ethan Wang edited comment on PHOENIX-4128 at 8/30/17 10:20 PM:
---------------------------------------------------------------

[~jamestaylor]
I meant the later. Since there is only one place using OutofRangeException. We 
can use alternative exception to get rid of this extra dependency.
throw new 
org.apache.commons.math3.exception.OutOfRangeException(tableSamplingRate, 0d, 
100d);
to:
throw new IllegalArgumentException("TableSamplingRate is out of bound of 0 and 
100");


was (Author: aertoria):
[~jamestaylor]
I meant the later. Since only there is only one place using 
OutofRangeException. We can change from:
throw new 
org.apache.commons.math3.exception.OutOfRangeException(tableSamplingRate, 0d, 
100d);
to:
throw new IllegalArgumentException("TableSamplingRate is out of bound of 0 and 
100");

> CNF org/apache/commons/math3/exception/OutOfRangeException 
> -----------------------------------------------------------
>
>                 Key: PHOENIX-4128
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4128
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Mujtaba Chohan
>            Assignee: Ethan Wang
>            Priority: Minor
>             Fix For: 4.12.0
>
>
> {noformat}
> Error: org.apache.hadoop.hbase.DoNotRetryIOException: T: 
> org/apache/commons/math3/exception/OutOfRangeException
> >     at 
> > org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:92)
> >     at 
> > org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:58)
> >     at 
> > org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2163)
> >     at 
> > org.apache.phoenix.coprocessor.MetaDataEndpointImpl.dropColumn(MetaDataEndpointImpl.java:3243)
> >     at 
> > org.apache.phoenix.coprocessor.generated.MetaDataProtos$MetaDataService.callMethod(MetaDataProtos.java:16317)
> >     at 
> > org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:6082)
> >     at 
> > org.apache.hadoop.hbase.regionserver.HRegionServer.execServiceOnRegion(HRegionServer.java:3533)
> >     at 
> > org.apache.hadoop.hbase.regionserver.HRegionServer.execService(HRegionServer.java:3515)
> >     at 
> > org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32496)
> >     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2195)
> ...
> > Caused by: java.lang.NoClassDefFoundError: 
> > org/apache/commons/math3/exception/OutOfRangeException
> >     at 
> > org.apache.phoenix.parse.ParseNodeFactory.namedTable(ParseNodeFactory.java:404)
> >     at 
> > org.apache.phoenix.parse.PhoenixSQLParser.upsert_node(PhoenixSQLParser.java:5239)
> >     at 
> > org.apache.phoenix.parse.PhoenixSQLParser.oneStatement(PhoenixSQLParser.java:827)
> >     at 
> > org.apache.phoenix.parse.PhoenixSQLParser.statement(PhoenixSQLParser.java:519)
> >     at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:108)
> >     at 
> > org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1497)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to