[
https://issues.apache.org/jira/browse/PHOENIX-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151418#comment-16151418
]
Hadoop QA commented on PHOENIX-4153:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12885054/PHOENIX-4153.patch
against master branch at commit 1aabbfa0d04261d1cebba845deaebf4c4048ae62.
ATTACHMENT ID: 12885054
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
62 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+# echo "$MVN clean package javadoc:javadoc -DskipTests
-D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchJavadocWarnings.txt 2>&1"
+# $MVN clean package javadoc:javadoc -DskipTests
-D${PROJECT_NAME}PatchProcess > $PATCH_DIR/patchJavadocWarnings.txt 2>&1
+# javadocWarnings=`$GREP '\[WARNING\]' $PATCH_DIR/patchJavadocWarnings.txt |
$AWK '/Javadoc Warnings/,EOF' | $GREP warning | $AWK 'BEGIN {total = 0} {total
+= 1} END {print total}'`
+# {color:red}-1 javadoc{color}. The javadoc tool appears to have generated
`expr $(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages."
+# JIRA_COMMENT_FOOTER="Javadoc warnings:
$BUILD_URL/artifact/patchprocess/patchJavadocWarnings.txt
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1353//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1353//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1353//console
This message is automatically generated.
> Temporarily disable java doc warning check in QA builds
> -------------------------------------------------------
>
> Key: PHOENIX-4153
> URL: https://issues.apache.org/jira/browse/PHOENIX-4153
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4153.patch
>
>
> It would be good to temporarily disable java doc checks in our QA builds. I
> don't believe Phoenix devs have been looking at java doc errors and having
> our QA builds spend so much time in generating warnings which we haven't been
> looking at doesn't make a lot of sense right now. Also, our releases are not
> bound by whether or not there are java doc errors in our code. Once we have
> fixed all such warnings, we can disable it back.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
