[
https://issues.apache.org/jira/browse/PHOENIX-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159679#comment-16159679
]
Hadoop QA commented on PHOENIX-4165:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886200/4165-4.x-HBase-0.98.txt
against 4.x-HBase-0.98 branch at commit
2ad5d4b48c16743b3f3968a858f9da19c14070fa.
ATTACHMENT ID: 12886200
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1412//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1412//console
This message is automatically generated.
> Do not wait no new memory chunk can be allocated
> ------------------------------------------------
>
> Key: PHOENIX-4165
> URL: https://issues.apache.org/jira/browse/PHOENIX-4165
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.11.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 4.12.0
>
> Attachments: 4165-4.x-HBase-0.98.txt, 4165.txt, 4165-v2.txt,
> 4165-v3.txt, 4165-v4.txt, 4165-v4.txt
>
>
> Currently the code waits for up to 10s by fault for memory to become
> "available".
> I think it's better to fail immediately and the let the client retry rather
> than waiting on an HBase handler thread.
> In a first iteration we can simply set the max wait time to 0 (or perhaps
> even -1) so that we do not attempt to wait but fail immediately. All using
> code should already deal with InsufficientMemoryExceptions, since they can
> already happen right now,
> In a second step I'd suggest to actually remove the waiting code and config
> option completely.
> [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
