[
https://issues.apache.org/jira/browse/PHOENIX-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167256#comment-16167256
]
Hadoop QA commented on PHOENIX-4007:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12887222/PHOENIX-4007_v2.patch
against master branch at commit 052490e09f2271eaa84dc9ab123a62a87123a498.
ATTACHMENT ID: 12887222
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " (k INTEGER PRIMARY KEY, c1.a bigint, c2.b bigint)
GUIDE_POSTS_WIDTH=" + guidePostWidth);
+ String sql = "SELECT * FROM " + tableA + " UNION ALL SELECT * FROM " +
tableB + " UNION ALL SELECT * FROM " + tableWithNoStats;
+ estimatedBytes = add(estimatedBytes,
subPlan.getInnerPlan().getEstimatedBytesToScan());
+ estimateInfoTs = getMin(estimateInfoTs,
subPlan.getInnerPlan().getEstimateInfoTimestamp());
+ || (lhsPlan.getEstimatedRowsToScan() == null ||
rhsPlan.getEstimatedRowsToScan() == null)
+ || (lhsPlan.getEstimateInfoTimestamp() == null ||
rhsPlan.getEstimateInfoTimestamp() == null)) {
+ estimatedBytes = add(add(estimatedBytes,
lhsPlan.getEstimatedBytesToScan()), rhsPlan.getEstimatedBytesToScan());
+ estimatedRows = add(add(estimatedRows,
lhsPlan.getEstimatedRowsToScan()), rhsPlan.getEstimatedRowsToScan());
+ estimateInfoTs = getMin(lhsPlan.getEstimateInfoTimestamp(),
rhsPlan.getEstimateInfoTimestamp());
+ hasGuidePosts = (gps != GuidePostsInfo.NO_GUIDEPOST && gps !=
GuidePostsInfo.EMPTY_GUIDEPOST);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificTablesDMLIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SysTableNamespaceMappedStatsCollectorIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1443//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1443//console
This message is automatically generated.
> Surface time at which byte/row estimate information was computed in explain
> plan output
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-4007
> URL: https://issues.apache.org/jira/browse/PHOENIX-4007
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-4007_v1.patch, PHOENIX-4007_v2.patch
>
>
> As part of PHOENIX-3822, we surfaced byte and row estimates for queries in
> explain plan. Since we collect this information through stats collection, it
> would also be helpful to surface when this information was last updated to
> reflect its freshness. We already store last_stats_update_time in
> SYSTEM.STATS. So the task would be essentially surfacing
> last_stats_update_time as another column in the explain plan result set.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
