[ 
https://issues.apache.org/jira/browse/PHOENIX-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172155#comment-16172155
 ] 

James Taylor commented on PHOENIX-4215:
---------------------------------------

[~rajeshbabu] - thanks for the info. I have a fix that's part of PHOENIX-4178 
(will post patch shortly) in which I go through the regular 
MetaDataEndPointImpl.updateIndexState() when setting the 
INDEX_DISABLE_TIMESTAMP in this case too. If you could write a test in 
PartialIndexRebuilderIT, that'd be appreciated. Manual testing is good, but it 
doesn't prevent regressions.

To write the test, you'd just create your own Clock class and inject it as the 
other tests are doing. Just set 
{{QueryServices.INDEX_FAILURE_HANDLING_REBUILD_PERIOD}} in the setup to a 
reasonable value (not large enough to trigger batches in other tests) and 
UPSERT some rows with timestamps that will cause batching to occur. You can 
copy/paste other tests there.

We've done a lot of work stabilizing mutable indexing and writing tests was a 
large part of it. It's not the most sexy work, but it's important. Appreciate 
your efforts here.

> Partial index rebuild never complete after PHOENIX-3525 when rebuild period 
> is configured
> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4215
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4215
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4215_testcase.patch
>
>
> Currently the default value of phoenix.index.failure.handling.rebuild.period 
> is long max. When we configure it some thing like an hour or day then partial 
> index rebuild never complete and the index is never usable until recreate it. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to