[ 
https://issues.apache.org/jira/browse/PHOENIX-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vincent Poon updated PHOENIX-4214:
----------------------------------
    Attachment: PHOENIX-4214.master.v2.patch
                PHOENIX-4214-0.98-v2.patch

[~jamestaylor] Attaching an updated v2 patches for Master and 0.98.  Tests pass 
on 4.x-HBase-1.1 and 4.x-HBase-0.98

Main changes were 
- moving the scanReferenceCounter increment back into the try/finally block to 
ensure the scanner gets closed, by introducing a new boolean.
- setting the client retries limit properly, and tweaking the test timeouts

BTW, with [~samarthjain] 's help, I found that the HBase client does retry 
transparently when the exception is thrown from doPostScannerOpen when a region 
is splitting/closing, as long as the client retry settings are set properly.

> Scans which write should not block region split or close
> --------------------------------------------------------
>
>                 Key: PHOENIX-4214
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4214
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-4214-0.98-v2.patch, 
> PHOENIX-4214-4.x-HBase-0.98_v1.patch, PHOENIX-4214.master.v1.patch, 
> PHOENIX-4214.master.v2.patch, splitDuringUpsertSelect_wip.patch
>
>
> PHOENIX-3111 introduced a scan reference counter which is checked during 
> region preSplit and preClose.  However, a steady stream of UPSERT SELECT or 
> DELETE can keep the count above 0 indefinitely, preventing or greatly 
> delaying a region split or close.
> We should try to avoid starvation of the split / close request, and 
> fail/reject queries where appropriate.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to