[
https://issues.apache.org/jira/browse/PHOENIX-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185217#comment-16185217
]
Hadoop QA commented on PHOENIX-4187:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12889610/PHOENIX-4187-v2-master.patch
against master branch at commit 033a2fc2a91052a6db94da55d87c173d4dbdabab.
ATTACHMENT ID: 12889610
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("CREATE IMMUTABLE TABLE " +
dataTableFullName2 + " (PK1 VARCHAR, PK2 DATE PRIMARY KEY ROW_TIMESTAMP, KV1
VARCHAR, KV2 INTEGER)");
+ String.format("CREATE IMMUTABLE TABLE %s (ID BIGINT NOT
NULL, NAME VARCHAR, ZIP INTEGER CONSTRAINT PK PRIMARY KEY(ID ROW_TIMESTAMP))
%s",
+ //assert disabled timestamp is set correctly when index mutations
are processed on the server
+ + " (PK1 VARCHAR NOT NULL, PK2 DATE NOT NULL, KV1
VARCHAR, KV2 VARCHAR CONSTRAINT PK PRIMARY KEY(PK1, PK2 "
+ fail("Should not be able to create an index on a mutable table
that has a ROW_TIMESTAMP column");
+ long timeStamp =
result.getColumnLatest(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
emptyKVQualifier).getTimestamp();
+ long timeStamp =
result.getColumnLatest(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
emptyKVQualifier).getTimestamp();
+ + " (PK1 VARCHAR NOT NULL, PK2 DATE NOT NULL, KV1
VARCHAR, KV2 VARCHAR CONSTRAINT PK PRIMARY KEY(PK1, PK2 "
+ fail("Should not be able to create an index on a mutable table
that has a ROW_TIMESTAMP column");
+ long timeStamp =
result.getColumnLatest(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
emptyKVQualifier).getTimestamp();
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1494//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1494//console
This message is automatically generated.
> Use server timestamp for ROW_TIMESTAMP column when value is not specified
> -------------------------------------------------------------------------
>
> Key: PHOENIX-4187
> URL: https://issues.apache.org/jira/browse/PHOENIX-4187
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Thomas D'Silva
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4187.patch, PHOENIX-4187-v2-master.patch,
> PHOENIX-4187-v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
