[
https://issues.apache.org/jira/browse/PHOENIX-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186963#comment-16186963
]
Hadoop QA commented on PHOENIX-4239:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12889824/PHOENIX-4239_v4.patch
against master branch at commit 2a81efeb71f00c60f59ca7a5f912b57318c24f68.
ATTACHMENT ID: 12889824
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static void runIndexRebuilder(List<String> tables) throws
InterruptedException, SQLException {
+ private static void runIndexRebuilderAsync(final int interval, final
boolean[] cancel, String table) {
+ private static void runIndexRebuilderAsync(final int interval, final
boolean[] cancel, final List<String> tables) {
+ executor.scheduleWithFixedDelay(task, initialRebuildTaskDelay,
rebuildIndexTimeInterval, TimeUnit.MILLISECONDS);
+ public BuildIndexScheduleTask(RegionCoprocessorEnvironment env,
List<String> onlyTheseTables) {
+ this.onlyTheseTables = onlyTheseTables == null ? null :
ImmutableList.copyOf(onlyTheseTables);
+ LOG.debug(dataTableFullName + " does not contain " +
indexPTable.getName().getString());
+ LOG.debug("Still must wait " +
(indexStateCell.getTimestamp() + forwardOverlapDurationMs - currentTime) + "
before starting rebuild for " + indexTableFullName);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1501//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1501//console
This message is automatically generated.
> Fix flapping test in PartialIndexRebuilderIT
> --------------------------------------------
>
> Key: PHOENIX-4239
> URL: https://issues.apache.org/jira/browse/PHOENIX-4239
> Project: Phoenix
> Issue Type: Test
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4239.patch, PHOENIX-4239_v2.patch,
> PHOENIX-4239_v3.patch, PHOENIX-4239_v4.patch, PHOENIX-4239_v5.patch
>
>
> To get more info on this flapper:
> https://www.google.com/url?q=https%3A%2F%2Fbuilds.apache.org%2Fjob%2FPhoenix-master%2F1810%2FtestReport%2Fjunit%2Forg.apache.phoenix.end2end.index%2FPartialIndexRebuilderIT%2FtestIndexWriteFailureLeavingIndexActive%2F&sa=D&sntz=1&usg=AFQjCNEj0LexiK8bm4GzGex9JUvu0DBJag
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
