[
https://issues.apache.org/jira/browse/PHOENIX-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220899#comment-16220899
]
Hadoop QA commented on PHOENIX-4305:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12894115/PHOENIX-4305.patch
against master branch at commit fe13b257e5dfe29581b1c3265d79596f194954cd.
ATTACHMENT ID: 12894115
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 27 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ assertEquals("Column Value", "value2",
Bytes.toString(kvs.get(0).getValueArray(), kvs.get(0).getValueOffset(),
kvs.get(0).getValueLength()));
+ Iterator<Pair<byte[], List<Cell>>> iterator =
PhoenixRuntime.getUncommittedDataIterator(conn);
+ splitKey =
KeyValueUtil.createFirstOnRow(region.getRegionInfo().getStartKey().length == 0 ?
+ if (getComparator().compare(kv.getRowArray(), kv.getKeyOffset(),
kv.getKeyLength(), fk, 0, fk.length) <= 0) {
+ if (getComparator().compare(kv.getRowArray(), kv.getKeyOffset(),
kv.getKeyLength(), reader.getSplitkey(), 0, reader.getSplitkey().length) >= 0) {
+ if(getComparator().compare(kv.getRowArray(), kv.getKeyOffset(),
kv.getKeyLength(), reader.getSplitkey(), 0, reader.getSplitkey().length) < 0){
+ if (getComparator().compare(kv.getRowArray(), kv.getKeyOffset(),
kv.getKeyLength(), reader.getSplitkey(), 0, reader.getSplitkey().length) >= 0) {
+ kvsetIt =
kvsetAtCreation.tailSet(getHighest(KeyValueUtil.maybeCopyCell(key),
kvsetItRow)).iterator();
+ return
org.apache.hadoop.hbase.KeyValueUtil.createLastOnRow(kv.getRowArray(),
kv.getRowOffset(), kv.getRowLength(),
+ final Iterator<Pair<byte[], List<Cell>>> uncommittedDataIterator =
PhoenixRuntime.getUncommittedDataIterator(connection, true);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedImmutableNonTxStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SysTableNamespaceMappedStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedMutableTxStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedImmutableTxStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NonColumnEncodedImmutableNonTxStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedMutableNonTxStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NonColumnEncodedImmutableTxStatsCollectorIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1572//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1572//console
This message is automatically generated.
> Make use of Cell interface APIs where ever possible.
> ----------------------------------------------------
>
> Key: PHOENIX-4305
> URL: https://issues.apache.org/jira/browse/PHOENIX-4305
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 4.12.0
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Labels: HBase-2.0
> Fix For: 4.13.0
>
> Attachments: PHOENIX-4305.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
