[
https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235217#comment-16235217
]
James Taylor commented on PHOENIX-4333:
---------------------------------------
The concept is good, but how about outside of the loop if you just have this
check:
{code}
} catch (EOFException e) {
// We have read all guide posts
intersectWithGuidePosts = false;
}
}
+ gpsAvailableForAllRegions &= initialKeyBytes != currentKeyBytes;
if (!useStatsForParallelization) {
{code}
I also think we should set the estimatedRows and estimatedSize to what we've
found, but only set estimateInfoTimestamp to null if
!gpsAvailableForAllRegions. That way callers can choose to use or not use the
partial estimates based on estimateInfoTimestamp.
{code}
this.estimatedRows = estimates.rowsEstimate;
this.estimatedSize = estimates.bytesEstimate;
this.estimateInfoTimestamp = gpsAvailableForAllRegions ?
estimateTs : null;
{code}
> Stats - Incorrect estimate when stats are updated on a tenant specific view
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-4333
> URL: https://issues.apache.org/jira/browse/PHOENIX-4333
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.12.0
> Reporter: Mujtaba Chohan
> Assignee: Samarth Jain
> Priority: Major
> Attachments: PHOENIX-4333_test.patch, PHOENIX-4333_v1.patch
>
>
> Consider two tenants A, B with tenant specific view on 2 separate
> regions/region servers.
> {noformat}
> Region 1 keys:
> A,1
> A,2
> B,1
> Region 2 keys:
> B,2
> B,3
> {noformat}
> When stats are updated on tenant A view. Querying stats on tenant B view
> yield partial results (only contains stats for B,1) which are incorrect even
> though it shows updated timestamp as current.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
