[ 
https://issues.apache.org/jira/browse/PHOENIX-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238587#comment-16238587
 ] 

Geoffrey Jacoby edited comment on PHOENIX-4342 at 11/3/17 11:43 PM:
--------------------------------------------------------------------

In most cases that seems true (it simplifies the execute() logic a good bit), 
but changing getExplainPlan() to use the dataPlan results in this test failure:

[ERROR]   
DeleteIT.testPointDeleteRowFromTableWithImmutableIndex:371->testPointDeleteRowFromTableWithImmutableIndex:447
 expected:<[DELETE SINGLE ROW]> but was:<[CLIENT PARALLEL 1-WAY POINT LOOKUP ON 
1 KEY OVER T000014
    SERVER FILTER BY FIRST KEY ONLY]>

Presumably the test is expecting a MutationPlan ExplainPlan and confused by 
getting the underlying QueryPlan instead?

There's a similar test failure for the point delete local immutable index test.


was (Author: gjacoby):
In most cases that seems true (it simplifies the execute() logic a good bit), 
but changing getExplainPlan() to use the dataPlan results in this test failure:

[ERROR]   
DeleteIT.testPointDeleteRowFromTableWithImmutableIndex:371->testPointDeleteRowFromTableWithImmutableIndex:447
 expected:<[DELETE SINGLE ROW]> but was:<[CLIENT PARALLEL 1-WAY POINT LOOKUP ON 
1 KEY OVER T000014
    SERVER FILTER BY FIRST KEY ONLY]>

Presumably the test is expecting a MutationPlan ExplainPlan and confused by 
getting the underlying QueryPlan instead?

> Surface QueryPlan in MutationPlan
> ---------------------------------
>
>                 Key: PHOENIX-4342
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4342
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>         Attachments: PHOENIX-4342-v2.patch, PHOENIX-4342-v3.patch, 
> PHOENIX-4342-v4.patch, PHOENIX-4342.patch
>
>
> For DELETE statements, it'd be good to be able to get at the QueryPlan 
> through the MutationPlan so we can get more structured information at compile 
> time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to