[ 
https://issues.apache.org/jira/browse/PHOENIX-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241655#comment-16241655
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-4350:
--------------------------------------------------

Thanks [~anoop.hbase] for review.
bq. So this patch is against Alpha-4?
Yes it's for Alpha-4 only.

bq. In UngroupedAggregateRegionObserver there is a code with Thread.sleep (). 
This is ugly.. U can make use of the Region#waitForFlushes(long timeout) call 
here. Seems the code needs a max wait time also. So this timeout param was 
added. Will do as part of this issue or some other issue? Just pointing out. 
Tks.
The Thread.sleep() not for waiting for flushes but will look at the all places 
where we can use the APIs in another JIRA and work out. 

> Replace deprecated or changed Region methods with new APIs
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4350
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4350
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>              Labels: HBase-2.0
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4350.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to