[
https://issues.apache.org/jira/browse/PHOENIX-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278430#comment-16278430
]
Hadoop QA commented on PHOENIX-4436:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12900643/PHOENIX-4436.patch
against master branch at commit 88038a2dacb7aa1a90015163d4d75d04793e4e11.
ATTACHMENT ID: 12900643
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 3 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ tableName =
StringEscapeUtils.unescapeJava(config.get(PhoenixStorageHandlerConstants.PHOENIX_TABLE_NAME));
+ List<ColumnInfo> columnMetadata =
PhoenixUtil.getColumnInfoList(conn,
StringEscapeUtils.unescapeJava(tbl.getProperty
+ String tableName =
StringEscapeUtils.unescapeJava(tableProperties.getProperty(PhoenixStorageHandlerConstants
+ String tableName =
StringEscapeUtils.unescapeJava(jobConf.get(PhoenixStorageHandlerConstants.PHOENIX_TABLE_NAME));
+ tableName =
StringEscapeUtils.unescapeJava(config.get(PhoenixStorageHandlerConstants.PHOENIX_TABLE_NAME));
+ primaryKeyColumnList = PhoenixUtil.getPrimaryKeyColumnList(config,
StringEscapeUtils.unescapeJava(config.get
+ String tableName =
StringEscapeUtils.unescapeJava(tableParameterMap.get(PhoenixStorageHandlerConstants
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-hive/target/failsafe-reports/TEST-org.apache.phoenix.hive.HiveMapReduceIT
./phoenix-hive/target/failsafe-reports/TEST-org.apache.phoenix.hive.HiveTezIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1651//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1651//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1651//console
This message is automatically generated.
> Hive PhoenixStorageHandler doesn't work well with quoted namespace/table
> name.
> -------------------------------------------------------------------------------
>
> Key: PHOENIX-4436
> URL: https://issues.apache.org/jira/browse/PHOENIX-4436
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.13.0, 4.14.0
> Reporter: Sergey Soldatov
> Assignee: Sergey Soldatov
> Labels: HivePhoenix
> Attachments: PHOENIX-4436.patch
>
>
> With quoted schema name the table will be created, but not usable with an
> exception about '\' character. The reason is that job properties in Hive are
> stored using escaped java strings. So to correctly handle it we need to
> unescape.
> For quoted name the table creation would fail because we are using table name
> in PK name prefixed by 'pk_'. So the PK name comes incorrect like
> 'pk_"table_name"'. I think that there is no reason to generate constraint pk
> name and we may use the constant.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
