[
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282413#comment-16282413
]
Hadoop QA commented on PHOENIX-3837:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12901107/PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch
against master branch at commit ee728a4d19c004ad456b24cd228fb2351362472d.
ATTACHMENT ID: 12901107
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("ALTER INDEX "+indexName+" ON " +
testTable +" ACTIVE SET GUIDE_POSTS_WIDTH = 10");
+ "select GUIDE_POSTS_WIDTH from SYSTEM.\"CATALOG\" where
TABLE_NAME='" + indexName + "'");assertTrue(rs.next());
+ conn.createStatement().execute("ALTER INDEX "+indexName+" ON " +
testTable +" ACTIVE SET GUIDE_POSTS_WIDTH = 20");
+ "select GUIDE_POSTS_WIDTH from SYSTEM.\"CATALOG\" where
TABLE_NAME='" + indexName + "'");assertTrue(rs.next());
+ conn.createStatement().execute("ALTER INDEX "+indexName+" ON " +
testTable +" ACTIVE SET DISABLE_WAL=false");
+ conn.createStatement().execute("ALTER INDEX "+indexName+" ON " +
testTable +" ACTIVE SET DISABLE_WAL=true");
+ private static void asssertIsWALDisabled(Connection conn, String
fullTableName, boolean expectedValue) throws SQLException {
+ assertEquals(expectedValue, pconn.getTable(new
PTableKey(pconn.getTenantId(), fullTableName)).isWALDisabled());
+ ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (async=ASYNC)?
((SET?)p=fam_properties)?)
+ {ret = factory.alterIndex(factory.namedTable(null,
TableName.create(t.getSchemaName(), i.getName())), t.getTableName(), ex!=null,
PIndexState.valueOf(SchemaUtil.normalizeIdentifier(s.getText())), async!=null,
p); }
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ContextClassloaderIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1657//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1657//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1657//console
This message is automatically generated.
> Unable to set property on an index with Alter statement
> -------------------------------------------------------
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.10.0
> Reporter: Mujtaba Chohan
> Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch,
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00):
> Syntax error. Encountered "SET" at line 1, column 102.
> at
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)