Sergey Soldatov created PHOENIX-4456:
----------------------------------------

             Summary: queryserver script doesn't perform as expected.
                 Key: PHOENIX-4456
                 URL: https://issues.apache.org/jira/browse/PHOENIX-4456
             Project: Phoenix
          Issue Type: Bug
    Affects Versions: 4.13.0, 5.0.0
            Reporter: Sergey Soldatov
            Assignee: Sergey Soldatov
            Priority: Minor
             Fix For: 5.0.0, 4.14.0


Our queryserver.py is using a copy of daemon module. It has several flows:
1. it forks first, exit the parent process and after that create the pid file. 
So there is a gap between the queryserver.py finished and the pid file created.
2. The check for existing pid is happening in forked process, so if we start 
queryserver when there is already running one we wouldn't see the message that 
process is already running/started 

I've checked the more recent version from python 3.5 and it's still using the 
same logic.
for (2) I think we may add an additinal check to PidFile.__init__, so it will 
happen before we fork the daemon. For (1) there is an option to wait until pid 
file appears and only after exit the parent process.

FYI [~elserj]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to