Github user vincentpoon commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/290#discussion_r164537544
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java ---
@@ -312,6 +317,16 @@ private static QueryPlan addPlan(PhoenixStatement
statement, SelectStatement sel
return null;
}
+ // returns true if we can still use the index
+ // retuns false if we've been in PENDING_DISABLE too long - index
should be considered disabled
+ private static boolean isUnderPendingDisableThreshold(PhoenixStatement
statement, PTable indexTable) {
+ return EnvironmentEdgeManager
+ .currentTimeMillis() -
indexTable.getIndexDisableTimestamp() <= statement
--- End diff --
@JamesRTaylor I'm seeing the following issue with using
indexTableRef.getCurrentTime(). In my test, if set the index to
PENDING_DISABLE. I then perform a query, which uses the index as expected. If
I then advance the EnvironmentEdgeManager clock to beyond the threshold, then
perform the query again, it still uses the index because
indexTableRef.getCurrentTime() hasn't changed. Is this expected?
---
