Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/291#discussion_r166986822
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
    @@ -1038,32 +1038,21 @@ public void setValue(PColumn column, byte[] 
byteValue) {
             @Override
             public void delete() {
                 newMutations();
    -            // we're using the Tephra column family delete marker here to 
prevent the translation 
    -            // of deletes to puts by the Tephra's TransactionProcessor
    -            if (PTableImpl.this.isTransactional()) {
    -                Put put = new Put(key);
    -                if (families.isEmpty()) {
    -                    
put.add(SchemaUtil.getEmptyColumnFamily(PTableImpl.this), 
TransactionFactory.getTransactionFactory().getTransactionContext().getFamilyDeleteMarker(),
 ts,
    -                            HConstants.EMPTY_BYTE_ARRAY);
    -                } else {
    -                    for (PColumnFamily colFamily : families) {
    -                        put.add(colFamily.getName().getBytes(), 
TransactionFactory.getTransactionFactory().getTransactionContext().getFamilyDeleteMarker(),
 ts,
    -                                HConstants.EMPTY_BYTE_ARRAY);
    -                    }
    -                }
    -                deleteRow = put;                
    --- End diff --
    
    The pendingUpdates represent what is about to be written (i.e. the current 
batch of mutations). I think we need to leave it, though, if we want an old 
client to work with a new server. It doesn't hurt anything as far as I can see.


---

Reply via email to