James Taylor created PHOENIX-4603: ------------------------------------- Summary: Remove check for table existence in MetaDataClient.createTableInternal() Key: PHOENIX-4603 URL: https://issues.apache.org/jira/browse/PHOENIX-4603 Project: Phoenix Issue Type: Bug Reporter: James Taylor
Found some strange code in that should be removed. If a table is being created but the HBase metadata already exists, we can't assume one way or the other that it's encoded or not encoded. It's on the user to supply the correct existing encoding in that case. {code} byte[] tableNameBytes = SchemaUtil.getTableNameAsBytes(schemaName, tableName); boolean tableExists = true; try { HTableDescriptor tableDescriptor = connection.getQueryServices().getTableDescriptor(tableNameBytes); if (tableDescriptor == null) { // for connectionless tableExists = false; } } catch (org.apache.phoenix.schema.TableNotFoundException e) { tableExists = false; } if (tableExists) { encodingScheme = NON_ENCODED_QUALIFIERS; immutableStorageScheme = ONE_CELL_PER_COLUMN; } else ... {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)