[ https://issues.apache.org/jira/browse/PHOENIX-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367771#comment-16367771 ]
Maryann Xue commented on PHOENIX-4585: -------------------------------------- {quote}Not a huge deal, but do you think it's confusing that we have a dataPlan member variable on QueryCompiler but then we pass through the dataPlan to compileSingleFlatQuery for other code paths?{quote} I think this is fine. dataPlan and dataPlanMap are all local parameters in private methods in QueryCompiler. And maybe as part of PHOENIX-4616, there will only be a dataPlanMap member field in QueryCompiler and no more dataPlan field. > Prune local index regions used for join queries > ----------------------------------------------- > > Key: PHOENIX-4585 > URL: https://issues.apache.org/jira/browse/PHOENIX-4585 > Project: Phoenix > Issue Type: Improvement > Reporter: James Taylor > Assignee: Maryann Xue > Priority: Major > Attachments: PHOENIX-4585.patch > > > Some remaining work from PHOENIX-3941: we currently do not capture the data > plan as part of the index plan due to the way in which we rewrite the > statement during join processing. See comment here for more detail: > https://issues.apache.org/jira/browse/PHOENIX-3941?focusedCommentId=16351017&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16351017 -- This message was sent by Atlassian JIRA (v7.6.3#76005)