James Taylor created PHOENIX-4619:

             Summary: Process transactional updates to local index on 
                 Key: PHOENIX-4619
                 URL: https://issues.apache.org/jira/browse/PHOENIX-4619
             Project: Phoenix
          Issue Type: Bug
            Reporter: James Taylor

For local indexes, we'll want to continue to process updates on the 
server-side. After PHOENIX-4278, updates even for local indexes are occurring 
on the client-side. The reason is that we know the updates to the index table 
will be a local write and we can generate the write on the server side. Having 
a separate RPC and sending the updates across the wire would be tremendously 
inefficient. On top of that, we need the region boundary information which we 
have already in the coprocessor, but would need to retrieve it on the client 
side (with a likely race condition too if a split occurs after we retrieve it).

To fix this, we need to modify PhoenixTxnIndexMutationGenerator such that it 
can be use on the server-side as well. The main change will be to change this 
method signature to pass through an IndexMaintainer instead of a PTable (which 
isn't available on the server-side):
    public List<Mutation> getIndexUpdates(final PTable table, PTable index, 
List<Mutation> dataMutations) throws IOException, SQLException {

We can tweak the code that makes PhoenixTransactionalIndexer a noop for clients 
>= 4.14 to have it execute if the index is a local index. The one downside is 
that if there's a mix of local and global indexes on the same table, the index 
update calculation will be done twice. I think having a mix of index types 
would be rare, though, and we should advise against it.

This message was sent by Atlassian JIRA

Reply via email to