[
https://issues.apache.org/jira/browse/PHOENIX-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371775#comment-16371775
]
James Taylor commented on PHOENIX-4530:
---------------------------------------
+1. Thanks, [~vincentpoon]! One question, though: would the
UngroupedAggregateRegionObserver.preCompact() hook still cause the
stats.createCompactionScanner() to create and use its InternalScanner for stats
collection with this change?
> Do not collect delete markers during major compaction of table with disabled
> mutable indexes
> --------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4530
> URL: https://issues.apache.org/jira/browse/PHOENIX-4530
> Project: Phoenix
> Issue Type: Improvement
> Environment:
> Reporter: James Taylor
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-4530.master.v1.patch,
> PHOENIX-4530.master.v2.patch
>
>
> If major compaction occurs on a table with mutable indexes that have the
> INDEX_DISABLE_TIMESTAMP set, we currently permanently disable the index,
> forcing it to be manually rebuilt from scratch. This is to prevent it from
> potentially being corrupted as we need the delete markers to remain in order
> to guarantee the data table and index table remain in sync.
> An alternate approach (mentioned by [~an...@apache.org] during review) is to
> detect this case in a pre-compaction hook and set the compaction up so that
> delete markers are not removed. This would have the advantage that we
> wouldn't have to permanently disable the index and rebuild it from scratch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
