Vincent Poon commented on PHOENIX-4130:

Thanks [~rajeshbabu] , attached a v2 that fixes the TestIndexWriter issue, but 
MutableIndexFailureIT is failing and that test class is important for this 
patch.  Haven't had time to look into whether those failures are related to 
this patch or not.

> Avoid server retries for mutable indexes
> ----------------------------------------
>                 Key: PHOENIX-4130
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4130
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Assignee: Vincent Poon
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>         Attachments: PHOENIX-4130.addendum.master.patch, 
> PHOENIX-4130.v1.master.patch, PHOENIX-4130.v10.master.patch, 
> PHOENIX-4130.v2.master.patch, PHOENIX-4130.v3.master.patch, 
> PHOENIX-4130.v4.master.patch, PHOENIX-4130.v5.master.patch, 
> PHOENIX-4130.v6.master.patch, PHOENIX-4130.v7.master.patch, 
> PHOENIX-4130.v8.master.patch, PHOENIX-4130.v9.master.patch, 
> PHOENIX-4130_5.x-HBase-2.0.patch, PHOENIX-4130_5.x-HBase-2.0.v2.patch
> Had some discussions with [~jamestaylor], [~samarthjain], and [~vincentpoon], 
> during which I suggested that we can possibly eliminate retry loops happening 
> at the server that cause the handler threads to be stuck potentially for 
> quite a while (at least multiple seconds to ride over common scenarios like 
> splits).
> Instead we can do the retries at the Phoenix client that.
> So:
> # The index updates are not retried on the server. (retries = 0)
> # A failed index update would set the failed index timestamp but leave the 
> index enabled.
> # Now the handler thread is done, it throws an appropriate exception back to 
> the client.
> # The Phoenix client can now retry. When those retries fail the index is 
> disabled (if the policy dictates that) and throw the exception back to its 
> caller.
> So no more waiting is needed on the server, handler threads are freed 
> immediately.

This message was sent by Atlassian JIRA

Reply via email to