[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387441#comment-16387441 ]
Jepson commented on PHOENIX-4489: --------------------------------- [~karanmehta93] Very nice, i have compiled, tested, and been ok. > HBase Connection leak in Phoenix MR Jobs > ---------------------------------------- > > Key: PHOENIX-4489 > URL: https://issues.apache.org/jira/browse/PHOENIX-4489 > Project: Phoenix > Issue Type: Bug > Reporter: Karan Mehta > Assignee: Karan Mehta > Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4489.001.patch, PHOENIX-4489.002.patch, > PHOENIX-4489.4.x-HBase-0.98.001.patch > > > Phoenix MR jobs uses a custom class {{PhoenixInputFormat}} to determine the > splits and the parallelism of the work. The class directly opens up a HBase > connection, which is not closed after the usage. Independently running MR > jobs should not have any concern, however jobs that run through Phoenix-Spark > can cause leak issues if this is left unclosed (since those jobs run as a > part of same JVM). > Apart from this, the connection should be instantiated with > {{HBaseFactoryProvider.getHConnectionFactory()}} instead of the default one. > It can be useful if a separate client is trying to run jobs and wants to > provide a custom implementation of {{HConnection}}. > [~jmahonin] Any ideas? > [~jamestaylor] [~vincentpoon] Any concerns around this? -- This message was sent by Atlassian JIRA (v7.6.3#76005)