[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410226#comment-16410226 ]
ASF GitHub Bot commented on PHOENIX-4668: ----------------------------------------- GitHub user ChinmaySKulkarni opened a pull request: https://github.com/apache/phoenix/pull/296 PHOENIX-4668: Remove unnecessary table descriptor modification for SPLIT_POLICY column Removed the code which: removed the SPLIT_POLICY in the system catalog table descriptor and then added it and modified the table. This was earlier done as a workaround for HBASE-12570. We specifically add the SPLIT_POLICY when creating system tables already as part of the patch for PHOENIX-1674, hence this is no longer required. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-4668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #296 ---- commit 55df92b9df24e7ae6999f78aef5274c03e052e27 Author: Chinmay Kulkarni <chinmayskulkarni@...> Date: 2018-03-22T20:14:10Z PHOENIX-4668: Remove unnecessary table descriptor modification for SPLIT_POLICY column Removed the code which: removed the SPLIT_POLICY in the system catalog table descriptor and then added it and modified the table. This was earlier done as a workaround for HBASE-12570. We specifically add the SPLIT_POLICY when creating system tables already as part of the patch for PHOENIX-1674, hence this is no longer required. ---- > Remove unnecessary table descriptor modification for SPLIT_POLICY column > ------------------------------------------------------------------------ > > Key: PHOENIX-4668 > URL: https://issues.apache.org/jira/browse/PHOENIX-4668 > Project: Phoenix > Issue Type: Improvement > Reporter: Chinmay Kulkarni > Assignee: Chinmay Kulkarni > Priority: Major > > Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the > table descriptor with > newDesc.setValue(HTableDescriptor.SPLIT_POLICY, > MetaDataSplitPolicy.class.getName()), however we already have this mentioned > in the create statement DDL for system tables, so we can remove this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)