[
https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423319#comment-16423319
]
James Taylor commented on PHOENIX-4616:
---------------------------------------
Is the derived-table the only exception and if so can we test for that too in
some way?
Alternatively, we could have three base classes for QueryPlan:
- BaseQueryPlan (or FinalQueryPlan or PhysicalQueryPlan or LeafQueryPlan?)
- JoinQueryPlan
- IntermediateQueryPlan (or LogicalQueryPlan or NonLeafQueryPlan or
CompositeQueryPlan )
Then just have an optimize method on QueryPlan with an implementation on these
three classes.
If that's problematic, then go ahead and commit it as you have it.
> Move join query optimization out from QueryCompiler into QueryOptimizer
> -----------------------------------------------------------------------
>
> Key: PHOENIX-4616
> URL: https://issues.apache.org/jira/browse/PHOENIX-4616
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Priority: Major
> Attachments: PHOENIX-4616.patch
>
>
> Currently we do optimization for join queries inside QueryCompiler, which
> makes the APIs and code logic confusing, so we need to move join optimization
> logic into QueryOptimizer.
> Similarly, but probably with a different approach, we need to optimize UNION
> ALL queries and derived table sub-queries in QueryOptimizer.optimize().
> Please also refer to this comment:
> https://issues.apache.org/jira/browse/PHOENIX-4585?focusedCommentId=16367616&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16367616
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
