[
https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424584#comment-16424584
]
ASF GitHub Bot commented on PHOENIX-4579:
-----------------------------------------
Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/295#discussion_r178959364
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -1039,10 +1065,20 @@ private HTableDescriptor ensureTableCreated(byte[]
physicalTableName, PTableType
}
}
+ if (isMetaTable &&
SchemaUtil.isNamespaceMappingEnabled(PTableType.SYSTEM,
--- End diff --
@JamesRTaylor We already try to acquire a lock in the SYSMUTEX table inside
_ensureSystemTablesMigratedToSystemNamespace_ before we start migrating SYSTEM
tables to the SYSTEM namespace, so race conditions shouldn't be a problem here,
right? In case multiple clients execute this simultaneously, still only 1 would
be able to migrate the tables.
On a side-note, I still think it logically makes sense to move this to
inside _upgradeSystemTables_ for consistency with the method definition.
> Add a config to conditionally create Phoenix meta tables on first client
> connection
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-4579
> URL: https://issues.apache.org/jira/browse/PHOENIX-4579
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Mujtaba Chohan
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-4579.patch
>
>
> Currently we create/modify Phoenix meta tables on first client connection.
> Adding a property to make it configurable (with default true as it is
> currently implemented).
> With this property set to false, it will avoid lockstep upgrade requirement
> for all clients when changing meta properties using PHOENIX-4575 as this
> property can be flipped back on once all the clients are upgraded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
