[ https://issues.apache.org/jira/browse/PHOENIX-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435073#comment-16435073 ]
ASF GitHub Bot commented on PHOENIX-4575: ----------------------------------------- Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/297 @JamesRTaylor please review. Thanks @mujtabachohan for your initial patches. - Added nit changes as suggested by James on JIRA - Rebased with master - @ankitsinghal please check that this does not break anything related to your recent contributions corresponding to Query Log [PHOENIX-2715](https://issues.apache.org/jira/browse/PHOENIX-2715). Changes are made to SYSLOG ddl statement. "KEEP_DELETED_CELLS" is by default false now (before the default value was true). - Ran all UTs in the that are part of PHOENIX-2715 and ran UTs that are relevant to sys table creation and upgrade -> All passed. > Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property driven > -------------------------------------------------------------------------- > > Key: PHOENIX-4575 > URL: https://issues.apache.org/jira/browse/PHOENIX-4575 > Project: Phoenix > Issue Type: New Feature > Reporter: Mujtaba Chohan > Assignee: Chinmay Kulkarni > Priority: Major > Attachments: PHOENIX-4575.patch, PHOENIX-4575_v2.patch > > > This is to cater for circumstances where we need to alter state of > KEEP_DELETED_CELLS/VERSION on Phoenix meta tables. -- This message was sent by Atlassian JIRA (v7.6.3#76005)