[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435992#comment-16435992 ]
Ankit Singhal edited comment on PHOENIX-4683 at 4/12/18 5:36 PM: ----------------------------------------------------------------- [~vincentpoon], can you please close the connections created, especially for the 5.x branch. But it seems here we are creating a connection for every thread, we will run out in the problem mentioned in PHOENIX-4655 soon. we may need to solve connection management in Phoenix holistically like having a connection factory giving connection per pre-defined configuration instead of creating a new connection every time. FYI [~rajeshbabu] was (Author: an...@apache.org): [~vincentpoon], can you please close the connections created, especially for the 5.x branch. But it seems here we are creating a connection for every thread, we will run out in the problem mentioned in PHOENIX-4655 soon. we may need to solve connection management in Phoenix holistically like having a connection factory giving connection per pre-defined configuration instead of creating a new connection every time. FYI [~rajeshbabu] > Cap timeouts for stats precompact hook logic > -------------------------------------------- > > Key: PHOENIX-4683 > URL: https://issues.apache.org/jira/browse/PHOENIX-4683 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.13.0 > Reporter: Vincent Poon > Assignee: Vincent Poon > Priority: Major > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4683.v1.0.98.patch, PHOENIX-4683.v2.0.98.patch, > PHOENIX-4683.v3.0.98.patch, PHOENIX-4683.v4.0.98.patch, > PHOENIX-4683.v5.0.98.patch, PHOENIX-4683.v5.5.x.patch > > > In UngroupedAggregateRegionObserver#preCompact we call > DefaultStatisticsCollector.createCompactionScanner. It uses the env config > which in turn contains the RS server rpc timeout of 20 minutes. That's too > long for a compaction hook. > Like in PHOENIX-4169, we should cap the timeout so the compaction doesn't get > blocked. -- This message was sent by Atlassian JIRA (v7.6.3#76005)