ASF GitHub Bot commented on PHOENIX-4579:

Github user JamesRTaylor commented on the issue:

    Thanks for the updates, @ChinmaySKulkarni. Looks like you still need to 
rebase it. Also, one test that would be really valuable would be to:
    * disable auto upgrade
    * run execute upgrade
    * make some change to the HBase metadata of SYSTEM.CATALOG through  ALTER 
TABLE or direct HBase API call (for example, set VERSIONS to some value).
    * connect a client that create a new ConnectionQueryServices instance to be 
created(see UpdateCacheAcrossDifferentClientsIT for how to do that)
    * ensure that the metadata change to SYSTEM.CATALOG is not undone.
    * do the same with auto upgrade enabled (which might cause the change to be 
reverted which is ok - this is more for making sure we understand this flow in 
both cases)
    This test will ensure that when this hits production, if we have auto 
upgrade disabled, we can make manual changes to the SYSTEM.CATALOG.

> Add a config to conditionally create Phoenix meta tables on first client 
> connection
> -----------------------------------------------------------------------------------
>                 Key: PHOENIX-4579
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4579
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Mujtaba Chohan
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>         Attachments: PHOENIX-4579.patch
> Currently we create/modify Phoenix meta tables on first client connection. 
> Adding a property to make it configurable (with default true as it is 
> currently implemented).
> With this property set to false, it will avoid lockstep upgrade requirement 
> for all clients when changing meta properties using PHOENIX-4575 as this 
> property can be flipped back on once all the clients are upgraded.

This message was sent by Atlassian JIRA

Reply via email to