[ 
https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454340#comment-16454340
 ] 

Josh Elser commented on PHOENIX-4701:
-------------------------------------

{quote}I think the best approach would be to persist our [client 
metrics|http://phoenix.apache.org/metrics.html] in the SYSTEM.LOG instead of 
inventing a new mechanism. The metrics captures all the same information as 
your QueryLogInfo (and much more), rolls all the information up to a single set 
of metrics for each Phoenix statement (aggregating/merging parallel scans, 
etc), and can emits a single log line (which could be written in a single 
upsert statement)
{quote}
I like this idea. Trying to make the QueryLog as the source of truth for what 
is happening in a cluster sounds great.
{quote}I've attached a wip2 patch that writes using Phoenix APIs so that you 
can have a composite row key to allow querying, use salting, have the table be 
column encoded, and potentially add secondary indexes.
{quote}
Missed commenting on this the first time, but that's awesome, James!

> Improve schema of SYSTEM.LOG table
> ----------------------------------
>
>                 Key: PHOENIX-4701
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4701
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4701_wip1.patch, PHOENIX-4701_wip2.patch
>
>
> If possible, the SYSTEM.LOG table would benefit greatly  (3-5x perf gain) 
> from being declared as immutable with a column encoding of 1 byte and a 
> storage format of SINGLE_CELL_ARRAY_WITH_OFFSETS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to