[
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472518#comment-16472518
]
James Taylor commented on PHOENIX-4726:
---------------------------------------
[~xucang]. Thanks for the patch. You need to handle the upgrade path too.
That's what handles the incremental schema changes to SYSTEM.CATALOG when you
upgrade to a new minor release. See
ConnectionQueryServicesImpl.upgradeSystemCatalogIfRequired(). You'll need to
add another addColumnIfNotExists call here:
{code:java}
if (currentServerSideTableTimeStamp <
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0) {
metaConnection = addColumnsIfNotExists(
metaConnection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0,
PhoenixDatabaseMetaData.TRANSACTION_PROVIDER + " "
+ PTinyint.INSTANCE.getSqlTypeName());{code}
> save index build timestamp -- for SYNC case only.
> -------------------------------------------------
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2,
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP, or
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for
> quite some long time. And without a timestamp to indicate where it started,
> it's hard to tell if this is a legit running task or stuck...
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
