Github user churrodog commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/303#discussion_r191948329
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropColumnIT.java ---
    @@ -522,7 +523,8 @@ public void 
helpTestDroppingIndexedColDropsViewIndex(boolean isMultiTenant) thro
                 byte[] cq = column.getColumnQualifierBytes();
                 // there should be a single row belonging to VIEWINDEX2 
                 assertNotNull(viewIndex2 + " row is missing", 
result.getValue(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, cq));
    -            assertNull(results.next());
    +            // TODO enable this after we drop view indexes than need a 
dropped column 
    +//            assertNull(results.next());
    --- End diff --
    
    what about this TODO?


---

Reply via email to