[
https://issues.apache.org/jira/browse/PHOENIX-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502731#comment-16502731
]
Alex Araujo commented on PHOENIX-4774:
--------------------------------------
Thanks [~tdsilva]. The Maven build was successful (see output below). I also
ran with OpenJDK 1.8.0_172 locally and that finished. Any objections to
committing this and iterating on any 1.8 issues that come up?
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:53 h
[INFO] Finished at: 2018-06-05T23:45:43Z
[INFO] Final Memory: 183M/1418M
[INFO] ------------------------------------------------------------------------
+ [[ 0 != 0 ]]
+ JIRA_COMMENT='Here are the results of testing the latest attachment
[http://issues.apache.org/jira/secure/attachment/12926618/PHOENIX-4774.patch]
against master branch at commit d9007714a7e62dec1d8d8af05b98685396ba4a42.
ATTACHMENT ID: 12926618
\{color:green}+1 @author\{color}. The patch does not contain any @author
tags.
\{color:green}+0 tests included\{color}. The patch appears to be a
documentation, build,
or dev patch that doesn'\''t require tests.
\{color:green}+1 javac\{color}. The applied patch does not increase the
total number of javac compiler warnings.
\{color:green}+1 release audit\{color}. The applied patch does not
increase the total number of release audit warnings.
\{color:green}+1 lineLengths\{color}. The patch does not introduce lines
longer than 100
\{color:green}+1 core tests\{color}. The patch passed unit tests in .'
> Add support for JDK 1.8
> -----------------------
>
> Key: PHOENIX-4774
> URL: https://issues.apache.org/jira/browse/PHOENIX-4774
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Alex Araujo
> Assignee: Alex Araujo
> Priority: Major
> Labels: build
> Fix For: 5.0.0
>
> Attachments: PHOENIX-4774.patch
>
>
> Avatica (along with the rest of the world) is moving up to 1.8 in its next
> release. Phoenix should build on 1.8 as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
