Rajeshbabu Chintaguntla created PHOENIX-4786:
------------------------------------------------
Summary: Reduce log level to debug when logging new aggregate row
key found and added results for scan ordered queries
Key: PHOENIX-4786
URL: https://issues.apache.org/jira/browse/PHOENIX-4786
Project: Phoenix
Issue Type: Bug
Reporter: Rajeshbabu Chintaguntla
Assignee: Rajeshbabu Chintaguntla
Fix For: 5.0.0, 4.15.0
Currently we are logging key value when the new aggregate row found for scan
ordered queries which is info log. This is going to add lot of overhead to the
queries because sometimes we may write almost all the rows into log.
{noformat}
results.add(keyValue);
if (logger.isInfoEnabled()) {
logger.info(LogUtil.addCustomAnnotations("Adding new
aggregate row: "
+ keyValue
+ ",for current key "
+ Bytes.toStringBinary(currentKey.get(),
currentKey.getOffset(),
currentKey.getLength()) + ", aggregated
values: "
+ Arrays.asList(rowAggregators),
ScanUtil.getCustomAnnotations(scan)));
}
{noformat}
{noformat}
[root@ctr-e138-1518143905142-358323-01-000010 hbase]# grep "Adding new
aggregate row: "
hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-000010.log.* | wc -l
19082854
{noformat}
It's changed recently as part of PHOENIX-4742 so better to make it debug only.
{noformat}
- if (logger.isDebugEnabled()) {
- logger.debug(LogUtil.addCustomAnnotations("Adding new
aggregate row: "
+ if (logger.isInfoEnabled()) {
+ logger.info(LogUtil.addCustomAnnotations("Adding new
aggregate row: "
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
