[
https://issues.apache.org/jira/browse/PHOENIX-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534672#comment-16534672
]
Thomas D'Silva commented on PHOENIX-3383:
-----------------------------------------
+1 LGTM, Just some minor nits:
fix comments in WhereOptimizer:
{code}
// supports identifying combinations for *all*
combinations of (1,2),(A,B),(X,Y) or
- // AX, 1AY, 1BX, 1BY, 2AX, 2AY, 2BX, 2BY.
+ // 1AX, 1AY, 1BX, 1BY, 2AX, 2AY, 2BX, 2BY.
// FIXME: test case for this as none of our unit tests
exercise this.
{code}
{code}
/**
* Similar to KeyRange.coelesce, but con
*/
{code}
In WhereOptimizerTest, the extra concat isn't required:
{code}
- byte[] expectedStopRow =
ByteUtil.concat(ByteUtil.concat(PVarchar.INSTANCE.toBytes(tenantId),
ByteUtil.nextKey(PVarchar.INSTANCE.toBytes(entityId2))));
+ byte[] expectedStopRow =
ByteUtil.concat(PVarchar.INSTANCE.toBytes(tenantId),
ByteUtil.nextKey(PVarchar.INSTANCE.toBytes(entityId2)));
{code}
In RowKeySchemaTest conn is not required in getKeyPart
{code}
private static byte[] getKeyPart(Connection conn, PTable t, String... keys)
throws SQLException {
{code}
> Comparison between descending row keys used in RVC is reverse
> -------------------------------------------------------------
>
> Key: PHOENIX-3383
> URL: https://issues.apache.org/jira/browse/PHOENIX-3383
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Priority: Major
> Labels: DESC
> Fix For: 4.15.0
>
> Attachments: PHOENIX-3383-wip1.patch, PHOENIX-3383-wip5.patch,
> PHOENIX-3383-wip6.patch, PHOENIX-3383-wip7.patch, PHOENIX-3383_v1.patch,
> PHOENIX-3383_v2.patch, PHOENIX-3383_v3.patch, PHOENIX-3383_wip.patch,
> PHOENIX-3383_wip2.patch, PHOENIX-3383_wip3.patch
>
>
> See PHOENIX-3382, but the comparison for RVC with descending row key columns
> is the reverse of what it should be.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
