ASF GitHub Bot commented on PHOENIX-3534:

Github user twdsilva commented on a diff in the pull request:

    --- Diff: 
    @@ -1779,13 +2174,65 @@ public void createTable(RpcController controller, 
CreateTableRequest request,
    +                // The mutations to create a table are written in the 
following order:
    +                // 1. Write the child link as if the next two steps fail we
    +                // ignore missing children while processing a parent
    +                // 2. Update the encoded column qualifier for the parent 
table if its on a
    +                // different region server (for tables that use column 
qualifier encoding)
    +                // if the next step fails we end up wasting a few col 
    +                // 3. Finally write the mutations to create the table
    +                // From 4.15 the parent->child links are stored in a 
separate table SYSTEM.CHILD_LINK
    +                List<Mutation> childLinkMutations = 
    --- End diff --
    I filed PHOENIX-4810 and added a comment to reference this jira.

> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>                 Key: PHOENIX-3534
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3534
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 5.0.0, 4.15.0
>         Attachments: PHOENIX-3534.patch
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region 
> based on the server-side row locks being held for operations that impact a 
> table and all of it's views. For example, adding/removing a column from a 
> base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431), 
> when a new table is created we can do a lazy cleanup  of any rows that may be 
> left over from a failed DDL call (kudos to [~lhofhansl] for coming up with 
> this idea). To implement this efficiently, we'd need to also do PHOENIX-2051 
> so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on 
> checking our sequence numbers for each table/view before/after updating. Each 
> table/view row would be individually locked for their change (metadata for a 
> view or table cannot span regions due to our split policy), with the sequence 
> number being incremented under lock and then returned to the client.

This message was sent by Atlassian JIRA

Reply via email to