Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/307#discussion_r202108057
  
    --- Diff: phoenix-queryserver/src/it/bin/test_phoenixdb.sh ---
    @@ -0,0 +1,59 @@
    +#/usr/bin/env bash
    +
    +set -u
    +set -x
    +set -e
    +
    +function cleanup {
    +    set +e
    +    set +u
    +    kdestroy
    +    pushd ${PY_ENV_PATH}/bin
    +    . deactivate ""
    +    popd
    +    rm -rf $PY_ENV_PATH
    +}
    +
    +trap cleanup EXIT
    +
    +echo "LAUNCHING SCRIPT"
    +
    +LOCAL_PY=$1
    +PRINC=$2
    +KEYTAB_LOC=$3
    +KRB5_CFG_FILE=$4
    +PQS_PORT=$5
    +PYTHON_SCRIPT=$6
    +
    +PY_ENV_PATH=$( mktemp -d )
    +
    +conda create -y -p $PY_ENV_PATH || virtualenv $PY_ENV_PATH
    +
    +pushd ${PY_ENV_PATH}/bin
    +
    +# conda activate does stuff with unbound variables :(
    +set +u
    +. activate ""
    +
    +popd
    +
    +set -u
    +echo "INSTALLING COMPONENTS"
    +pip install -e file:///${LOCAL_PY}/requests-kerberos
    +pip install -e file:///${LOCAL_PY}/phoenixdb-module
    +
    +export KRB5_CONFIG=$KRB5_CFG_FILE
    +cat $KRB5_CONFIG
    +export KRB5_TRACE=/dev/stdout
    +
    +#echo "RUNNING KINIT"
    +kinit -kt $KEYTAB_LOC $PRINC
    --- End diff --
    
    > I just tried on the command line and MAC OS (Heimdal) kinit does not 
require a directory
    
    Yeah, convention is to use `${tmpdir}/krb5cc_$(current-user uid)`.
    
    > pass the when executing python or just continue running in the same 
shell, which is why I stopped attempts to make ny further reductions to the 
shell script
    
    Oh right, I forgot they would bash the environment. Let's just let this be 
for now. Will be easier to come back to it later.


---

Reply via email to