[
https://issues.apache.org/jira/browse/PHOENIX-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554357#comment-16554357
]
ASF GitHub Bot commented on PHOENIX-4817:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/311#discussion_r204795871
--- Diff: bin/traceserver.py ---
@@ -116,8 +116,10 @@
# " -Xdebug
-Xrunjdwp:transport=dt_socket,address=5005,server=y,suspend=n " + \
# " -XX:+UnlockCommercialFeatures -XX:+FlightRecorder
-XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true" + \
-java_cmd = '%(java)s $PHOENIX_OPTS ' + \
- '-cp ' + hbase_config_path + os.pathsep +
phoenix_utils.phoenix_traceserver_jar + os.pathsep +
phoenix_utils.phoenix_client_jar + \
+java_cmd = '%(java)s ' + \
--- End diff --
The issue is that subprocess doesn't handle shell variable expansion "in
the command". Subprocess has API to provide an environment to the process being
run.
`$PHOENIX_OPTS` and `$PHOENIX_TRACESERVER_OPTS` should be placed into the
subprocess's environment, not just dropped.
> Phoenix Tracing Web Application
> -------------------------------
>
> Key: PHOENIX-4817
> URL: https://issues.apache.org/jira/browse/PHOENIX-4817
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.0, 4.13.1
> Environment: maven 3+, JDK7
> Reporter: Vitaliy
> Priority: Minor
> Labels: patch
>
> # Phoenix Tracing Web Application can not be started, because traceserver.py
> does not contain required dependencies.
> # The path to the folder webapp is incorrectly specified, so Phoenix Tracing
> Web Application can not find this folder.
> # Phoenix Tracing Web Application does not check null value where it is
> needed, so the application can not load List, Dependency Tree and Features.
> # Phoenix Tracing Web Application creates a query with the wrong table
> column names.
> # Phoenix Tracing Web Application has only the default tracing-table name
> (SYSTEM.TRACING_STATS) and does not get tracing-table name via hbase-site.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
