Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/314#discussion_r205981788
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java ---
@@ -88,4 +88,10 @@
* @return
*/
boolean requiresFinalEvaluation();
+
+ /**
+ *
+ * @return
+ */
+ boolean isConstantIfChildrenAllConstant();
--- End diff --
It's not clear that we need this. We already rollup determinism and
isStateless for the expression tree. If determinism ==
Determinism.PER_STATEMENT or Determinism.ALWAYS and isStateless is true, then
we know an expression is a constant. We have a utility for this in
ExpressionUtil.isConstant(Expression).
---
