+1 Ran mvn verify on all branches. A few errors passed after manually running. Otherwise everything passed.
On Wed, Nov 7, 2018 at 10:12 AM James Taylor <jamestay...@apache.org> wrote: > +1 > > Ran various manual sanity tests around loading/querying/indexing data > > On Tue, Nov 6, 2018 at 3:53 PM Thomas D'Silva <tdsi...@salesforce.com> > wrote: > > > +1 > > > > Ran some manual tests with indexes, sequences. > > Regarding Artem's question in PhoenixDatabaseMetdata.getDriverVersion() > we > > only return the majorVersion.minorVersion > > perhaps you can file a JIRA to also inlcude the patch version. > > > > On Fri, Nov 2, 2018 at 11:47 AM, Josh Elser <els...@apache.org> wrote: > > > > > +1 (binding) > > > > > > Some observations: > > > * Some cruft (0.98, 1.2, and 1.3 seem to have this), not a blocker, > > > but good to ensure is cleaned up in the future: > > > ./bin/phoenix_utils.pyc > > > > > > Everything else looks good to me. > > > > > > - Josh > > > > > > On Tue, Oct 30, 2018 at 4:47 PM Vincent Poon < > vincent.poon...@gmail.com> > > > wrote: > > > > > > > > Hello Everyone, > > > > > > > > This is a call for a vote on Apache Phoenix 4.14.1 RC0. This is a > patch > > > > release of Phoenix 4.14 and is compatible with Apache HBase 0.98, > 1.1, > > > 1.2, > > > > 1.3, 1.4. The release includes both a > > > > source-only release and a convenience binary release for each > supported > > > > HBase version. > > > > > > > > This release has feature parity with supported HBase versions and > > > includes > > > > critical bug fixes for secondary indexes. > > > > > > > > The source tarball, including signatures, digests, etc can be found > at: > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-0.98-rc0/src/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.1-rc0/src/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.2-rc0/src/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.3-rc0/src/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.4-rc0/src/ > > > > > > > > The binary artifacts can be found at: > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-0.98-rc0/bin/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.1-rc0/bin/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.2-rc0/bin/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.3-rc0/bin/ > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache- > > > phoenix-4.14.1-HBase-1.4-rc0/bin/ > > > > > > > > For a complete list of changes, see: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > projectId=12315120&version=12343452 > > > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/vincentpoon.asc > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > > > > > > The hash and tag to be voted upon: > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h= > > > b27613ea409f81cd2d5a51e4ab14b1ca4d81f478 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > h=refs/tags/v4.14.1-HBase-0.98-rc0 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h= > > > ca3597d842d00fbb4cda5adb84fcb792ab06f3a2 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > h=refs/tags/v4.14.1-HBase-1.1-rc0 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h= > > > 537ad56e0683fedf252aef49dd82ca2851151385 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > h=refs/tags/v4.14.1-HBase-1.2-rc0 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h= > > > 1c06ebc1c54a736b3c390c58ca949450bf16e6a7 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > h=refs/tags/v4.14.1-HBase-1.3-rc0 > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h= > > > c5ca547923bedf28a2d1b96362adb7e5e40dbd0c > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > h=refs/tags/v4.14.1-HBase-1.4-rc0 > > > > > > > > > > > > Vote will be open for at least 72 hours. Please vote: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Thanks, > > > > The Apache Phoenix Team > > > > > >
