I think we need to keep the file in the /dist/release/phoenix directory because that's where the final binaries will be downloaded from, and where KEYS is expected to be found. I think the dev and release KEYS were probably meant to stay in sync, they just accidentally got out of sync.
If we only want one then I'd say put everything in the release KEYS. On Fri, May 24, 2019 at 2:09 PM Thomas D'Silva <[email protected]> wrote: > The sample VOTE email in "How to do a release" > https://phoenix.apache.org/release.html references the KEYS in the dev > folder. > I think some of the older VOTE emails refer to KEYS file in the release > folder, I will remove that file since the KEYS file in dev is a superset. > I think the comparison of sha512 values is case insensitive so it should be > fine. > > > > > On Fri, May 24, 2019 at 1:24 PM Artem Ervits <[email protected]> > wrote: > > > vote: 4.14.2 RC2-HBase-1.4 > > +1 (non-binding) > > > > signatures and sums for src and bin: OK > > installed on pseudodistributed hadoop 2.8.5 with hbase 1.4.10RC0: OK > > sqlline various commands: OK > > compile from src java-1.8.0-openjdk-1.8.0.212.b04-0: OK > > build with tests: OK > > performance.py 1M: OK > > > > KEYS are in two locations, maybe we should remove one? > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > looks like Dev keys are superset of release. > > > > also noticed sha512 for source is identical but one is uppercase and the > > other is lower. > > > > 1c1,3 > > < > > > > > eb8cf8553a53a0732e4717f5d523a23f9432a6f5eb3769dc330c4e75999460ce36cbe6e21908ecb7cbf05089e6214682bce634e1f3274205cb13f1bfcb8683fe > > *apache-phoenix-4.14.2-HBase-1.4-src.tar.gz > > --- > > > apache-phoenix-4.14.2-HBase-1.4-src.tar.gz: > > > EB8CF855 3A53A073 2E4717F5 D523A23F 9432A6F5 EB3769DC 330C4E75 999460CE > > 36CBE6E2 > > > 1908ECB7 CBF05089 E6214682 BCE634E1 F3274205 CB13F1BF CB8683FE > > > > > > On Fri, May 24, 2019 at 2:59 PM Vincent Poon <[email protected]> > > wrote: > > > > > +1 > > > deployed locally on pseudo-distributed cluster, ran some basic sanity > > tests > > > > > > > > > On Fri, May 24, 2019 at 11:50 AM Andrew Purtell <[email protected]> > > > wrote: > > > > > > > Let me raise this on dev@hbase > > > > > > > > On Fri, May 24, 2019 at 11:45 AM Thomas D'Silva > > > > <[email protected]> wrote: > > > > > > > > > We can't commit PHOENIX-5269 to 4.14-HBase-1.3 until HBase 1.3.5 is > > > > > released. > > > > > > > > > > On Fri, May 24, 2019 at 5:21 AM Mihir Monani < > [email protected] > > > > > > > > wrote: > > > > > > > > > > > I think we can't commit this patch to 4.14.2-HBase-1.3 as hbase > is > > > not > > > > > > release from branch-1.3 yet. Last release was 1.3.4 > > > > > > <https://github.com/apache/hbase/tree/rel/1.3.4> on April 15 and > > > > > > HBASE-22374 was committed on May 9 . > > > > > > > > > > > > > > > > > > > > > > > > On Fri, May 24, 2019 at 5:35 PM Mihir Monani < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > On checking further, PHOENIX-5269 is committed to > 4.14-HBase-1.4, > > > but > > > > > > it's > > > > > > > not committed to 4.14.-HBase-1.3 version. > > > > > > > > > > > > > > On Fri, May 24, 2019 at 5:24 PM Mihir Monani < > > > [email protected] > > > > > > > > > > > > wrote: > > > > > > > > > > > > > >> Should we wait for PHOENIX-5269? I think it would be commited > in > > > 1-2 > > > > > > >> days. > > > > > > >> > > > > > > >> On Fri, May 24, 2019 at 5:57 AM [email protected] < > > > [email protected]> > > > > > > >> wrote: > > > > > > >> > > > > > > >>> +1 again based on inspection of the release artifacts. > > > > > > >>> > > > > > > >>> On Thursday, May 23, 2019, 2:09:52 PM PDT, Thomas > D'Silva < > > > > > > >>> [email protected]> wrote: > > > > > > >>> > > > > > > >>> Hello Everyone, > > > > > > >>> > > > > > > >>> This is a call for a vote on Apache Phoenix 4.14.2 RC2. This > > is a > > > > > patch > > > > > > >>> release of Phoenix 4.14 and is compatible with Apache HBase > 1.3 > > > and > > > > > > 1.4. > > > > > > >>> The release includes both a source-only release and a > > convenience > > > > > > binary > > > > > > >>> release for each supported HBase version. > > > > > > >>> > > > > > > >>> This release has feature parity with supported HBase versions > > and > > > > > > >>> includes > > > > > > >>> several critical bug fixes. > > > > > > >>> > > > > > > >>> The source tarball, including signatures, digests, etc can be > > > found > > > > > at: > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.2-HBase-1.3-rc2/src/ > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.2-HBase-1.4-rc2/src/ > > > > > > >>> > > > > > > >>> The binary artifacts can be found at: > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.2-HBase-1.3-rc2/bin/ > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.2-HBase-1.4-rc2/bin/ > > > > > > >>> > > > > > > >>> For a complete list of changes, see: > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315120&version=12344379 > > > > > > >>> > > > > > > >>> Artifacts are signed with my "CODE SIGNING KEY": DFD86C02 > > > > > > >>> > > > > > > >>> KEYS file available here: > > > > > > >>> https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > > > >>> > > > > > > >>> The hash and tag to be voted upon: > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=13ce47cf4214c9c78e8fec5f96fb861410677817 > > > > > > >>> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=a86206a006c85afd5884a015d6fe452d823ac626 > > > > > > >>> > > > > > > >>> Vote will be open for at least 72 hours. Please vote: > > > > > > >>> > > > > > > >>> [ ] +1 approve > > > > > > >>> [ ] +0 no opinion > > > > > > >>> [ ] -1 disapprove (and reason why) > > > > > > >>> > > > > > > >>> Thanks, > > > > > > >>> The Apache Phoenix Team > > > > > > >>> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> -- > > > > > > >> Mihir Monani > > > > > > >> (+91)-9429473434 > > > > > > >> > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Mihir Monani > > > > > > > (+91)-9429473434 > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Mihir Monani > > > > > > (+91)-9429473434 > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Andrew > > > > > > > > Words like orphans lost among the crosstalk, meaning torn from > truth's > > > > decrepit hands > > > > - A23, Crosstalk > > > > > > > > > >
