Vote: -1, for the same reason as Artem above. (I also agree with Artem that the Maven problems he identified aren't blockers for this release, though we need to fix them for the future. Maybe make them blockers for 4.15 to make sure we remember? Chinmay, wdyt?)
Rat-check: OK Keys: OK mvn clean verify: FAILED [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.034 s <<< FAILURE! - in org.apache.phoenix.pherf.ConfigurationParserTest [ERROR] testConfigReader(org.apache.phoenix.pherf.ConfigurationParserTest) Time elapsed: 0.015 s <<< FAILURE! java.lang.AssertionError at org.apache.phoenix.pherf.ConfigurationParserTest.testConfigReader(ConfigurationParserTest.java:121) There was also a failure in SaltedIndexIT, but it appears to be a flapper because it passed when run standalone. Running the ConfigurationParserTest in my IDE, I get the following stack trace. Looks like another case where a scenario name isn't being set: java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191) at org.apache.phoenix.pherf.configuration.Scenario.getName(Scenario.java:168) [lots of JAXB internals] at org.apache.phoenix.pherf.ConfigurationParserTest.writeXML(ConfigurationParserTest.java:239) at org.apache.phoenix.pherf.ConfigurationParserTest.testConfigReader(ConfigurationParserTest.java:68) Geoffrey On Mon, Aug 12, 2019 at 2:29 PM Artem Ervits <artemerv...@gmail.com> wrote: > vote: 4.14.3RC1-HBase-1.4 > -1 (non-binding) > > sqlline-thin various commands: OK > inserted rows with Java: OK > ran code with Spark 2.3.3: OK > signatures and sums for src and bin: OK though Swaroopa's keys are in dev > KEYS and not in release, same issue as past votes. The announcement does > point to the right KEYS however. > installed binary on pseudodistributed hadoop 2.8.5 with hbase 1.4.10: OK > mvn install -DskipTests 1.8.0_222-b10: OK > mvn package: NOK > > filed: https://issues.apache.org/jira/browse/PHOENIX-5439 > https://issues.apache.org/jira/browse/PHOENIX-5440 > > but I didn't think those were blockers until I tried running mvn package > w/out any flags > > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 0.074 s <<< FAILURE! - in org.apache.phoenix.pherf.ConfigurationParserTest > [ERROR] testConfigReader(org.apache.phoenix.pherf.ConfigurationParserTest) > Time elapsed: 0.022 s <<< FAILURE! > java.lang.AssertionError > at > > org.apache.phoenix.pherf.ConfigurationParserTest.testConfigReader(ConfigurationParserTest.java:121) > > [INFO] Running org.apache.phoenix.pherf.ResultTest > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 4.415 s - in org.apache.phoenix.pherf.ResultTest > [INFO] Running org.apache.phoenix.pherf.result.impl.XMLResultHandlerTest > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 0.037 s - in org.apache.phoenix.pherf.result.impl.XMLResultHandlerTest > [INFO] > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] ConfigurationParserTest.testConfigReader:121 > [INFO] > [ERROR] Tests run: 31, Failures: 1, Errors: 0, Skipped: 0 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary for Apache Phoenix 4.14.3-HBase-1.4: > [INFO] > [INFO] Apache Phoenix ..................................... SUCCESS [ > 2.070 s] > [INFO] Phoenix Core ....................................... SUCCESS [02:53 > min] > [INFO] Phoenix - Flume .................................... SUCCESS [ > 3.357 s] > [INFO] Phoenix - Kafka .................................... SUCCESS [ > 2.396 s] > [INFO] Phoenix - Pig ...................................... SUCCESS [01:03 > min] > [INFO] Phoenix Query Server Client ........................ SUCCESS [ > 13.323 s] > [INFO] Phoenix Query Server ............................... SUCCESS [ > 13.345 s] > [INFO] Phoenix - Pherf .................................... FAILURE [ > 12.053 s] > [INFO] Phoenix - Spark .................................... SKIPPED > [INFO] Phoenix - Hive ..................................... SKIPPED > [INFO] Phoenix Client ..................................... SKIPPED > [INFO] Phoenix Server ..................................... SKIPPED > [INFO] Phoenix Assembly ................................... SKIPPED > [INFO] Phoenix - Tracing Web Application .................. SKIPPED > [INFO] Phoenix Load Balancer .............................. SKIPPED > > > also see issue with opening archives > > apache-phoenix-4.14.3-HBase-1.4-src/src/main/config/checkstyle/checker.xml > tar: Ignoring unknown extended header keyword `SCHILY.dev' > tar: Ignoring unknown extended header keyword `SCHILY.ino' > tar: Ignoring unknown extended header keyword `SCHILY.nlink' > > KEYS are in two locations, maybe we should remove one, see issue above > https://dist.apache.org/repos/dist/release/phoenix/KEYS > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > On Thu, Aug 8, 2019 at 7:47 PM swaroopa kadam <swaroopa.kada...@gmail.com> > wrote: > > > Hello Everyone, > > > > I take my -1 back, the test failure came as a false alarm. > > > > The source tarball, including signatures, digests, etc can be found at: > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.3-rc1/src/ > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.4-rc1/src/ > > > > The binary artifacts can be found at: > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.3-rc1/bin/ > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.4-rc1/bin/ > > > > For a complete list of changes, see: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315120&version=12345601 > > > > Artifacts are signed with my "CODE SIGNING KEY": 48B7807D95F127B5 > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > The tag to be voted upon: > > https://github.com/apache/phoenix/releases/tag/4.14.3-HBase-1.3-rc1 > > https://github.com/apache/phoenix/releases/tag/4.14.3-HBase-1.4-rc1 > > > > The vote will be open for at least 72 hours. Please vote: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and the reason why) > > > > Thank you. > > > > On Wed, Aug 7, 2019 at 9:55 PM William Shen <wills...@marinsoftware.com> > > wrote: > > > > > Thanks Artem for bringing up HBASE-22728 to help Phoenix stay ahead of > > the > > > game :) > > > > > > On Wed, Aug 7, 2019 at 3:41 PM Artem Ervits <artemerv...@gmail.com> > > wrote: > > > > > > > Didn't mean to insinuate to block 4.14.3, just wanted to understand > > where > > > > community is focusing. Thank you all for chiming in. > > > > > > > > On Wed, Aug 7, 2019, 6:30 PM Geoffrey Jacoby <gjac...@apache.org> > > wrote: > > > > > > > > > I agree with William that there's no need to block 4.14.3's 1.3 and > > > > > 1.4-based releases on HBase 1.5. Soon-but-later, when HBase 1.5 > > lands I > > > > > think we should do a followup 4.14.3 (or .4, if other critical > JIRAs > > > are > > > > > necessary) release based on 1.5. > > > > > > > > > > Then, based on the branch EOL discussions the HBase list is having > > > right > > > > > now, and the status of 4.15, we can decide which branches to > support > > > > going > > > > > forward. > > > > > > > > > > Geoffrey > > > > > > > > > > On Wed, Aug 7, 2019 at 3:00 PM William Shen < > > > wills...@marinsoftware.com> > > > > > wrote: > > > > > > > > > > > If HBase does not patch 1.3 or 1.4 for the Jackson CVE, the > > > > > recommendation > > > > > > for concerned users would be to use 1.5. I think that sounds like > > we > > > > > would > > > > > > want to get a 1.5 branch for 4.14, unless we think 4.15 is almost > > > > ready? > > > > > > > > > > > > Either way, I am not sure if this would need to block 4.14.3, > since > > > it > > > > > will > > > > > > take some time for this to play out? > > > > > > > > > > > > On Wed, Aug 7, 2019 at 11:10 AM Artem Ervits < > > artemerv...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > As described in HBASE-22728, are we planning to get a 1.5 > branch > > > for > > > > > 4.14 > > > > > > > or are we targeting 4.15 and 5.x for HBase 1.5? > > > > > > > > > > > > > > On Tue, Aug 6, 2019, 5:01 PM swaroopa kadam < > > > > > swaroopa.kada...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > non-binding -1 > > > > > > > > > > > > > > > > Uncovered a blocker Jira PHOENIX-5348. > > > > > > > > I will be back with RC2 soon. > > > > > > > > > > > > > > > > Thank you. > > > > > > > > > > > > > > > > On Tue, Aug 6, 2019 at 12:58 PM swaroopa kadam < > > > > > > > swaroopa.kada...@gmail.com > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hello Everyone, > > > > > > > > > > > > > > > > > > This is a call for a vote on Apache Phoenix 4.14.3 RC1. > This > > > is a > > > > > > patch > > > > > > > > > release of Phoenix 4.14 and is compatible with Apache HBase > > 1.3 > > > > and > > > > > > > > > 1.4. The release includes both a source-only release and a > > > > > > convenience > > > > > > > > > binary > > > > > > > > > release for each supported HBase version. > > > > > > > > > > > > > > > > > > This release includes critical bug fixes and improvements > for > > > > > > secondary > > > > > > > > > indexes -- making them self-consistent. > > > > > > > > > > > > > > > > > > The source tarball, including signatures, digests, etc can > be > > > > found > > > > > > at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.3-rc1/src/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.4-rc1/src/ > > > > > > > > > > > > > > > > > > The binary artifacts can be found at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.3-rc1/bin/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.14.3-HBase-1.4-rc1/bin/ > > > > > > > > > > > > > > > > > > For a complete list of changes, see: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315120&version=12345601 > > > > > > > > > > > > > > > > > > Artifacts are signed with my "CODE SIGNING KEY": > > > 48B7807D95F127B5 > > > > > > > > > > > > > > > > > > KEYS file available here: > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > > > > > > > > > > > > > > > The tag to be voted upon: > > > > > > > > > > > > > > > https://github.com/apache/phoenix/releases/tag/4.14.3-HBase-1.3-rc1 > > > > > > > > > > > > > > > https://github.com/apache/phoenix/releases/tag/4.14.3-HBase-1.4-rc1 > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. Please vote: > > > > > > > > > > > > > > > > > > [ ] +1 approve > > > > > > > > > [ ] +0 no opinion > > > > > > > > > [ ] -1 disapprove (and the reason why) > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > The Apache Phoenix Team > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > Swaroopa Kadam > > > > > > > > > [image: https://]about.me/swaroopa_kadam > > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://about.me/swaroopa_kadam?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > Swaroopa Kadam > > > > > > > > [image: https://]about.me/swaroopa_kadam > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://about.me/swaroopa_kadam?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Swaroopa Kadam > > [image: https://]about.me/swaroopa_kadam > > < > > > https://about.me/swaroopa_kadam?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api > > > > > >
