Thanks Lars, I agree that we need backwards compatibility tests. The past couple of RC's for 4.15 have been rejected mainly due to backwards compatibility issues. Good to mark this as a blocker for 4.16.
On Sat, Dec 7, 2019 at 10:39 AM [email protected] <[email protected]> wrote: > I filed a blocker bug for 4.16.0 to improve backward compatibility and > tests for the same.And I wow to veto any 4.16 release without that in > place. We've almost reached the point at which Phoenix becomes > unreleasable, this has to stop. > > For 4.15.0 we have no chance but to release without that. > However, there are some bigger features waiting to be committed soon (View > TTL, et al). I will also veto those until we have 4.15.0 out, so that we do > not destabilize 4.15.0 further. (Or we can create a set of 4.15 branches > now and control commits there.) > > It pains me a bit that as a community we seem to fail following well known > software engineering principles (always releasable code base, agile > principles, frequent releases, comprehensive test suite, etc, etc). > > Cheers. > > -- Lars > > On Friday, December 6, 2019, 1:57:50 PM PST, [email protected] < > [email protected]> wrote: > > Sigh. Agreed. > I change my vote to -1 (binding) as well. > > On Friday, December 6, 2019, 1:51:35 PM PST, Chinmay Kulkarni < > [email protected]> wrote: > > Thanks for the votes everyone. Thanks for finding this bug Geoffrey, great > debugging! > Unfortunately this looks like a blocker and I change my vote to -1 > (binding). > > We will be back with an RC3 once this bug gets resolved. > > On Fri, Dec 6, 2019 at 12:33 PM Geoffrey Jacoby <[email protected]> > wrote: > > > -1 (binding) > > > > - Built from source (OK) > > - Verified signatures and checksums (OK) > > - Ran mvn clean verify (OK) > > - Tried to run all my use case's DDL with a 4.14 client and a 4.15 server > > whose system tables weren't upgraded yet. It failed on an ALTER TABLE ADD > > COLUMN for lack of SYSTEM.CHILD_LINK when doing child view lookup. > > > > Filed PHOENIX-5605. At the least, if the community decides this is an > > acceptable limitation, there should be a clear error message saying that > > this isn't allowed. But this seems to me to break our backward > > compatibility guarantees. > > > > Geoffrey > > > > On Fri, Dec 6, 2019 at 11:17 AM Nitesh Maheshwari > > <[email protected]> wrote: > > > > > +1 (Non-binding) > > > > > > Checked the following: > > > > > > - Built from source > > > - Verified signatures > > > - Verified checksums > > > - Some sanity testing > > > - Verified schema, table, views, index creation > > > - Looked at some queries and their EXPLAIN PLAN output > > > > > > Thanks, > > > Nitesh > > > > > > On Thu, Dec 5, 2019 at 8:41 PM Neha Gupta <[email protected]> > wrote: > > > > > > > +1 (non-binding) > > > > > > > > - Verified checksums : OK > > > > - Verified signatures : OK > > > > - Built from source (4.15.0-HBase-1.3) : OK > > > > - mvn verify : OK > > > > - Did some basic DDL, upserts, deletes, querying, and everything > seems > > > > fine. > > > > - Created indexes and views queried them and dropped them, everything > > > seems > > > > fine. > > > > > > > > > > > > On Thu, Dec 5, 2019 at 7:47 PM Daniel Wong > > > > <[email protected]> wrote: > > > > > > > > > +1 (non-binding) > > > > > I did the following: > > > > > New install on hbase latest 1.3 version on local hbase. > > > > > Ran several queries and checked explain plan for right > scans/filters > > > > > including full table scans, range scans, point lookups, skip scan > > > > filters, > > > > > server side filters. > > > > > > > > > > On Thu, Dec 5, 2019 at 6:40 PM Chinmay Kulkarni < > > > > > [email protected]> > > > > > wrote: > > > > > > > > > > > +1 (Binding) > > > > > > > > > > > > - Built from source (4.15.0-HBase-1.3) : OK > > > > > > - mvn verify : OK > > > > > > - Did some basic DDL, upserts, deletes, querying, and everything > > > looked > > > > > > fine : OK > > > > > > - Verified checksums : OK > > > > > > - Verified signatures : OK > > > > > > - mvn clean apache-rat:check : OK > > > > > > > > > > > > On Thu, Dec 5, 2019 at 5:24 PM xinyi yan <[email protected]> > > wrote: > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > Tested locally on my environment, I created tables, views, > index, > > > and > > > > > > > upsert data in different clients(4.15 and 4.14). All behaviors > > are > > > > > > expected > > > > > > > this time. > > > > > > > > > > > > > > Xinyi Yan > > > > > > > > > > > > > > On Thu, Dec 5, 2019 at 1:02 PM Thomas D'Silva < > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > Tested with standalone local hbase (version 1.3.5). Create a > > > table > > > > > > with a > > > > > > > > few indexes and ran some queries. > > > > > > > > Everything looks good. > > > > > > > > > > > > > > > > On Thu, Dec 5, 2019 at 11:35 AM Chinmay Kulkarni < > > > > > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > A correction: > > > > > > > > > > > > > > > > > > Please use the CODE SIGNING KEY: "702918B6" > > > > > > > > > > > > > > > > > > Sorry for the inconvenience. > > > > > > > > > > > > > > > > > > On Wed, Dec 4, 2019 at 11:15 AM Chinmay Kulkarni < > > > > > > > > > [email protected]> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > *REMINDER - [VOTE] Release of Apache Phoenix 4.15.0 RC2* > > > > > > > > > > > > > > > > > > > > Just sending out a friendly reminder to everyone to > please > > > vote > > > > > on > > > > > > > > Apache > > > > > > > > > > Phoenix 4.15.0 RC2 (thanks Lars). > > > > > > > > > > > > > > > > > > > > On Tue, Dec 3, 2019 at 8:50 AM [email protected] < > > > > > [email protected]> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > >> +1 (binding) > > > > > > > > > >> I did the following: > > > > > > > > > >> - built from source > > > > > > > > > >> - verified tar ball > > > > > > > > > >> - ran with tip of HBase branch-1 > > > > > > > > > >> - created tables, global and local ndexes, views, and > > > indexes > > > > on > > > > > > > views > > > > > > > > > >> with both 4.15.0 and older client > > > > > > > > > >> - upserted data alternately with a 4.15.0 and older > client > > > > > > > > > >> - queried while upserting with 4.15.0 and older client > > > > > > > > > >> - caused some splits while upserting or querying > > > > > > > > > >> - Nothing weird in the logs. > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> -- Lars > > > > > > > > > >> > > > > > > > > > >> On Monday, December 2, 2019, 9:46:07 PM PST, Chinmay > > > > > Kulkarni > > > > > > < > > > > > > > > > >> [email protected]> wrote: > > > > > > > > > >> > > > > > > > > > >> Hello Everyone, > > > > > > > > > >> > > > > > > > > > >> This is a call for a vote on Apache Phoenix 4.15.0 RC2. > > This > > > > is > > > > > > the > > > > > > > > next > > > > > > > > > >> minor release of Phoenix 4, compatible with Apache HBase > > > 1.3, > > > > > > 1.4, & > > > > > > > > > >> 1.5. The release includes both a source-only release > and a > > > > > > > convenience > > > > > > > > > >> binary release for each supported HBase version. > > > > > > > > > >> > > > > > > > > > >> This release has feature parity with supported HBase > > > versions > > > > > and > > > > > > > > > includes > > > > > > > > > >> the following improvements: > > > > > > > > > >> - Support for multi-region SYSTEM.CATALOG > > > > > > > > > >> - Omid integration with Phoenix > > > > > > > > > >> - Orphan view tool > > > > > > > > > >> - Separation of the Phoenix-Connectors and > > > Phoenix-Queryserver > > > > > > > > projects > > > > > > > > > >> - 150+ bug fixes > > > > > > > > > >> and much more > > > > > > > > > >> > > > > > > > > > >> The source tar ball, including signatures, digests, etc > > can > > > be > > > > > > found > > > > > > > > at: > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.3-rc2/src/ > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.4-rc2/src/ > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.5-rc2/src/ > > > > > > > > > >> > > > > > > > > > >> The binary artifacts can be found at: > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.3-rc2/bin/ > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.4-rc2/bin/ > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/apache-phoenix-4.15.0-HBase-1.5-rc2/bin/ > > > > > > > > > >> > > > > > > > > > >> For a complete list of changes, see: > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315120&version=12343162 > > > > > > > > > >> > > > > > > > > > >> Artifacts are signed with my "CODE SIGNING KEY": > > > > > > > > > >> 7C5FC713DE4C59D7 > > > > > > > > > >> > > > > > > > > > >> KEYS file available here: > > > > > > > > > >> https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > > > > > > >> > > > > > > > > > >> The hash and tag to be voted upon: > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=1f85c13a0935a0705f69b0122aa75ab8d6a634f2 > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.15.0-HBase-1.3-rc2 > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=e776bb0bc677b8f56571b06130a8fbf080b0a985 > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.15.0-HBase-1.4-rc2 > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=81ec7d22937cf3f83a4cb2be35d0ce5974dd1fec > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.15.0-HBase-1.5-rc2 > > > > > > > > > >> > > > > > > > > > >> Vote will be open for at least 72 hours. Please vote: > > > > > > > > > >> > > > > > > > > > >> [ ] +1 approve > > > > > > > > > >> [ ] +0 no opinion > > > > > > > > > >> [ ] -1 disapprove (and reason why) > > > > > > > > > >> > > > > > > > > > >> Thanks, > > > > > > > > > >> The Apache Phoenix Team > > > > > > > > > >> > > > > > > > > > >> -- > > > > > > > > > >> Chinmay Kulkarni > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Chinmay Kulkarni > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Chinmay Kulkarni > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Chinmay Kulkarni > > > > > > > > > > > > > > > > > > > > > -- > > > > > Daniel Wong > > > > > Salesforce > > > > > Mobile: 628.217.1808 > > > > > > > > > > > > > > > > > -- > Chinmay Kulkarni > -- Chinmay Kulkarni
