stoty commented on a change in pull request #62:
URL: https://github.com/apache/phoenix-omid/pull/62#discussion_r468390934
##########
File path: common/src/main/java/org/apache/omid/NetworkUtils.java
##########
@@ -34,6 +36,14 @@
public static String getDefaultNetworkInterface() {
+ try (DatagramSocket s=new DatagramSocket()) {
Review comment:
Reading the code, the interface name IS configurable, which should cover
99% of real-world use cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
