joshelser commented on a change in pull request #2: URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566902974
########## File path: phoenix-shaded-commons-cli/pom.xml ########## @@ -0,0 +1,169 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <!-- +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +--> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.phoenix.thirdparty</groupId> + <artifactId>phoenix-thirdparty</artifactId> + <version>1.1.0-SNAPSHOT</version> + </parent> + <artifactId>phoenix-shaded-commons-cli</artifactId> + <name>Apache Phoenix Patched and Relocated (Shaded) Commons-CLI</name> + <description> + Pulls down commons-cli, patches it, compiles, and then relocates/shades. + </description> + <build> + <plugins> + <plugin> + <!--Clean needs to purge src/main/java since this is where + the unpack of commons-cli is overlaid. Do it for usual + clean goal but also before we unpack in case patches + delete/add files. We use src/main/java instead of dir + under 'target' because the jar plugin is dumb, hard to + make it source from other then src/main/java.--> + <artifactId>maven-clean-plugin</artifactId> + <executions> + <execution> + <id>pre-generate-sources</id> + <phase>generate-sources</phase> + <goals> + <goal>clean</goal> + </goals> + </execution> + </executions> + <configuration> + <filesets> + <fileset> + <directory>${basedir}/src/main/java</directory> + <includes> + <include>**/**</include> + </includes> + <followSymlinks>false</followSymlinks> + </fileset> + </filesets> + </configuration> + </plugin> + <plugin> + <!--Download our dependency src, i.e. commons-cli, and + unpack it. Overlays src/main/java so ready for + compile-time (the jar plugin expects src in + src/main/java)--> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-dependency-plugin</artifactId> + <version>3.1.1</version> Review comment: Would be good to pull versions into pluginManagement in the parent in a follow-on. ########## File path: phoenix-shaded-commons-cli/pom.xml ########## @@ -0,0 +1,169 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <!-- +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +--> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.phoenix.thirdparty</groupId> + <artifactId>phoenix-thirdparty</artifactId> + <version>1.1.0-SNAPSHOT</version> + </parent> + <artifactId>phoenix-shaded-commons-cli</artifactId> + <name>Apache Phoenix Patched and Relocated (Shaded) Commons-CLI</name> + <description> + Pulls down commons-cli, patches it, compiles, and then relocates/shades. + </description> + <build> + <plugins> + <plugin> + <!--Clean needs to purge src/main/java since this is where + the unpack of commons-cli is overlaid. Do it for usual + clean goal but also before we unpack in case patches + delete/add files. We use src/main/java instead of dir + under 'target' because the jar plugin is dumb, hard to + make it source from other then src/main/java.--> + <artifactId>maven-clean-plugin</artifactId> + <executions> + <execution> + <id>pre-generate-sources</id> + <phase>generate-sources</phase> + <goals> + <goal>clean</goal> + </goals> + </execution> + </executions> + <configuration> + <filesets> + <fileset> + <directory>${basedir}/src/main/java</directory> + <includes> + <include>**/**</include> + </includes> Review comment: Isn't this implied? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
