[
https://issues.apache.org/jira/browse/PHOENIX-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Istvan Toth updated PHOENIX-6554:
---------------------------------
Description:
The Pherf script does not use long and short option names consistently.
for example:
-t and --thin are for specifying the the thin PQS URL,
and
-z and --zookeeper are for the ZK quorum
but
-schemaFile is used to specify the schema file, and
--schemaFile does not work.
IMO options that look like long options should also be accepted with double
dash, or we could just invent new short options for them (which would break
backwards compatibility).
i.e. instead of
{code:java}
options.addOption("schemaFile", true,
"Regex or file name for the Test phoenix table schema .sql to
use.");
{code}
we could have one of the following:
{code:java}
options.addOption("sf", "schemaFile", true,
"Regex or file name for the Test phoenix table schema .sql to
use.");
options.addOption("schemaFile", "schemaFile", true,
"Regex or file name for the Test phoenix table schema .sql to
use.");
{code}
was:
The Pherf script does not use long and short option names consistently.
for example:
-t and --thin are for specifying the the thin PQS URL,
and
-z and --zookeeper are for the ZK quorum
but
-schemaFile is used to specify the schema file, and
--schemaFile does not work.
IMO options that look like long options should also be affected with double
dash, or we could just invent new short options for them (which would break
backwards compatibility).
i.e. instead of
{code:java}
options.addOption("schemaFile", true,
"Regex or file name for the Test phoenix table schema .sql to
use.");
{code}
we could have one of the following:
{code:java}
options.addOption("sf", "schemaFile", true,
"Regex or file name for the Test phoenix table schema .sql to
use.");
options.addOption("schemaFile", "schemaFile", true,
"Regex or file name for the Test phoenix table schema .sql to
use.");
{code}
> Pherf CLI option long/short option names do not follow conventions
> ------------------------------------------------------------------
>
> Key: PHOENIX-6554
> URL: https://issues.apache.org/jira/browse/PHOENIX-6554
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.2.0
> Reporter: Istvan Toth
> Priority: Minor
>
> The Pherf script does not use long and short option names consistently.
> for example:
> -t and --thin are for specifying the the thin PQS URL,
> and
> -z and --zookeeper are for the ZK quorum
> but
> -schemaFile is used to specify the schema file, and
> --schemaFile does not work.
> IMO options that look like long options should also be accepted with double
> dash, or we could just invent new short options for them (which would break
> backwards compatibility).
> i.e. instead of
> {code:java}
> options.addOption("schemaFile", true,
> "Regex or file name for the Test phoenix table schema .sql to
> use.");
> {code}
> we could have one of the following:
> {code:java}
> options.addOption("sf", "schemaFile", true,
> "Regex or file name for the Test phoenix table schema .sql to
> use.");
> options.addOption("schemaFile", "schemaFile", true,
> "Regex or file name for the Test phoenix table schema .sql to
> use.");
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
