Java code wise the current shim system is fine. The packaging up to 1.0.2 is nightmarish, with having to manually exclude hbase-1 artifacts if you use HBase 2. However, that is mostly fixed by OMID-188.
I will check if Omid works with the current HBase 3 snapshot without modifications, and remove the shims if it does. On Fri, Apr 29, 2022 at 12:19 AM Josh Elser <[email protected]> wrote: > +1 > > If we're dropping Phoenix 4.x imminently, that means dropping HBase 1.x > and we should follow suit in Omid. > > A "beta" HBase 3.0 is probably not too, too far away. I would consider > how "nice" the current shim logic is in Omid (i.e. is it actually > helpful? nice to work with? effective?), and make the call on that. > However, HBase 3.0 should not drop any API from HBase 2.x, so we should > not _have_ to shim anything. > > 1.1.0 as a release version makes sense to me for the API reason you gave. > > On 4/19/22 4:53 AM, Istvan Toth wrote: > > Hi! > > > > When Geoffrey proposed releasing Phoenix 5.2.0, I asked for time to > release > > a new Omid version first, as there are a lot of unreleased fixes in > master. > > > > One of those fixes removes the need to add a lot of explicit excludes for > > the Omid HBase-1 artifacts when depending on Omid for HBase 2. > > > > However, the discussion on dropping HBase 1.x support from Phoenixhas > been > > re-opened, and so far there are no objections. > > > > We can either release the Omid master as is (perhaps with some dependency > > version bumps), or we could just drop HBase 1.x support, and simplify the > > project structure quite a bit for the next version. > > > > In case we drop support for Hbase 1, we also need to decide whether to > keep > > the maven build infrastructure (shims and flatten-maven-plugin) for > > supporting different HBase releases for an upcoming HBase 3 release (if > the > > API changes will require it), or to remove it altogether ? > > > > We'll need to update the dependencies and exclusions in Phoenix either > way. > > > > What do you think ? > > Can we make an official decision to drop Phoenix 4.x soon, and drop > HBase 1 > > support from Omid for the next release, > > or should I just go ahead with the Omid next release process, and worry > > about removing the HBase 1.x support from Omid later ? > > > > Also, as we're making incompatible changes to the way Omid is to be > > consumed via maven, I think that we should bump the version either to > > 1.1.0, or 2.0.0. (I prefer 1.1.0, as the API doesn't change.) > > > > Looking forward to your input, > > > > Istvan > > > -- *István Tóth* | Staff Software Engineer [email protected] <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> <https://www.cloudera.com/> ------------------------------
